add config templating

[saltydk]

Suggestion for resolving #109 whilst keeping IPv6 functionality.

[sammcj]

Any update on getting this merged @Tecnativa?

[pedrobaeza]

I don't get why you need all the .template stuff for the IPv6 thing.

[saltydk]

I don't get why you need all the .template stuff for the IPv6 thing.

Because of the linked issue while I cannot reproduce it personally there seems to be cases where haproxy doesn't start, guessing docker swarm edge case.

[pedrobaeza]

Yeah, but for this I think there's no need of having 2 files. Just inject the environment variable on the file. Another think I don't like is the extra added package.

[saltydk]

As far as I know haproxy doesn't allow templating in bind, if that was what you were going for.

[pedrobaeza]

OK, what about the extra package?

[saltydk]

The alternative sed solution is posted in the issue but didn't get any feedback on which was preferred.

[pedrobaeza]

Then please proceed with one not adding more load to the container.

[saltydk]

Done.

[saltydk]

Removed the -f flag so it matches the current entrypoint logic https://github.com/docker-library/haproxy/blob/master/2.2/alpine/docker-entrypoint.sh

[pedrobaeza]

Is the CI fault related?

[saltydk]

It has error'ed for a while, don't think it is related to any of this PR.

[pedrobaeza]

@josep-tecnativa please check how to fix the CI in this project.

[saltydk]

Yeah, I can't find any faults. Should I change the default to be IPv6 enabled? Currently it fallbacks to IPv4 only.

[saltydk]

Given that the CI throws a IPv6 error:

Stderr: | error during connect: Get "http://localhost:32768/v1.24/containers/ebcc16f045797cd6b7c937952c84bfbdfa9d034a206d0997162ceae82a75a0f6/json": read tcp [::1]:48582->[::1]:32768: read: connection reset by peer

[pedrobaeza]

Try to see. I think the IPv6 support was merged because a green CI.

[saltydk]

It is failing to install the test

The current project could not be installed: No file/folder found for package docker-socket-proxy
If you do not want to install the current project use --no-root

[saltydk]

I've inverted the setting but it didn't change anything. The PR that I made last time didn't fail as a PR but failed once merged so something must have happened in-between.

[saltydk]

Added back the -f flag since it doesn't work with the old entrypoint style. The image works fine when deployed on my box for what it is worth.

[saltydk]

Made it a bit cleaner by replacing the built-in entrypoint. Still cannot fix the build-test.

[saltydk]

I replaced the existing one since it was cleaner

…

On Thu, 1 Feb 2024, 08:49 josep-tecnativa, ***@***.***> wrote: Made it a bit cleaner by replacing the built-in entrypoint. Still cannot fix the build-test. Why did you deleted the entrypoint in Dockerfile? — Reply to this email directly, view it on GitHub <#111 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSIMLQNUNVEZ3HM5RZVWFLYRNCILAVCNFSM6AAAAABATNHPB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQGY4TONZVG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[josep-tecnativa]

Check this out : #116 . I think that by running poetry update, the error is fixed.

[saltydk]

Will do when I am back at the PC, thanks.

…

On Thu, 1 Feb 2024, 10:19 josep-tecnativa, ***@***.***> wrote: Check this out : #116 <#116> . I think that by running poetry update, the error is fixed. — Reply to this email directly, view it on GitHub <#111 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSIMLVWQNWQKQI2GIO5ZLTYRNM2RAVCNFSM6AAAAABATNHPB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQHA3DKNJYGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[pedrobaeza]

Well, now it's just rebase this branch over current master

[saltydk]

Done.

[josep-tecnativa]

Done.

The change you made here:
https://github.com/Tecnativa/docker-socket-proxy/compare/b4adb630a04a8cf3076588672307787a430af4a9..72e5eeafc411b34f8ee9a1938f39685488b6a425#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L37
Wouldn't result in the automatic script execution being skipped when the container starts?

[saltydk]

No, it just replaces the script that was already present in the base image.

[saltydk]

For reference: https://github.com/docker-library/haproxy/blob/2913aa63fe4594a441e41f13e2c820092064a032/2.2/alpine/Dockerfile#L100-L106

[josep-tecnativa]

For reference: https://github.com/docker-library/haproxy/blob/2913aa63fe4594a441e41f13e2c820092064a032/2.2/alpine/Dockerfile#L100-L106

Understood, thank you for the clarification. From my side, it looks good, I'll merge it.

[jscheytt]

Thank you @saltydk @pedrobaeza @josep-tecnativa for getting this merged! The problem I was encountering in #109 is solved by this if I set the env var DISABLE_IPV6: "1".

Maybe we could add some info about this to the README?

[pedrobaeza]

Yes, can you please make a PR adding such information?

[jscheytt]

Sure: #119