YlvaK-W6-Survey-with-React#449
Open
YlvaKarlsson wants to merge 10 commits intoTechnigo:masterfrom
Open
Conversation
smirrebinx
reviewed
Mar 22, 2023
smirrebinx
left a comment
smirrebinx
left a comment
There was a problem hiding this comment.
You seem to have met the requirements for the assignment and there are no errors in the console log and according to Lighthouse the score for Accessibility and Best Practices are 100% and there are no errors in the Wave check. You did a really great job on the survey, be proud!
| <label htmlFor="favoriteplace" className="favoriteplace-label"> | ||
| <p>What is your favorite place/surrounding?</p> | ||
| <br /> | ||
| <input |
There was a problem hiding this comment.
If you add a unique label to each radio button the radio buttons will be accessible and more user-friendly. That way you can click on the question and check the radio button and you don't have to click on the radio button.
| setSlider(event.target.value); | ||
| } | ||
| return ( | ||
| <div className="slide-container"> |
| </div> | ||
| )} | ||
| <div className="progress-bar"> | ||
| <div className="progress-bar-fill" style={{ width: `${progress}% ` }} /> |
| align-items: center; | ||
| min-height: 100vh; | ||
| padding: 25px; | ||
| background-image: url('../public/background-survey.jpg'); |
There was a problem hiding this comment.
Pretty background image and colors on the form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ylva-karlsson-week6-survey.netlify.app/