Week 12 - Frida/Alexander Labyrinth #214
Week 12 - Frida/Alexander Labyrinth #214Alexander-Gabor wants to merge 19 commits intoTechnigo:masterfrom
Conversation
MalinSkill
left a comment
MalinSkill
left a comment
There was a problem hiding this comment.
Great work, brilliant theme and Lottie animation!
Something to look into,
The footer interferes with the options buttons on some steps, when there is a lot of text in the description.
Keep it up, it looks awesome you are doing great!
| justify-content: center; | ||
| align-items: center; | ||
| overflow: hidden; | ||
| pointer-events: none; |
There was a problem hiding this comment.
Great solution, to not be able to click again
| <LoadingWrapper> | ||
| {isLoading && <Loading />} | ||
| </LoadingWrapper> |
There was a problem hiding this comment.
Could the loading wrapper styling be in the loading component and then conditionally render all at once?
| import React from 'react' | ||
| import { useSelector, useDispatch } from 'react-redux' | ||
| import game, { generateMoves } from 'reducers/game' | ||
| import styled, { keyframes } from 'styled-components/macro'; |
| export const GameBoard = () => { | ||
| const currentLocation = useSelector((store) => store.game.currentLocation) | ||
| const dispatch = useDispatch(); | ||
| // const isLoading = useSelector((store) => store.ui.isLoading) |
There was a problem hiding this comment.
If not intended to be used in production, this could be removed
| ); | ||
| })} | ||
| </OptionBox> | ||
| {currentLocation.coordinates === '1,3' && <div><WinnerText>Well done! You made it out alive!</WinnerText> <Button onClick={() => restartGame()}>Restart</Button></div>} |
There was a problem hiding this comment.
To show the end of game, you could also have rendered based on actions left. That way it would work even if the backend gets updated with additional coordinates
3 participants
No description provided.