Open
Conversation
Co-authored-by: Nora Terbocs <noraterbocs@users.noreply.github.com>
Joanna-Philips
left a comment
Joanna-Philips
left a comment
There was a problem hiding this comment.
Jennifer & Nora, I think your project shows a high level of skill and effort. Well done!
What I liked:
- Components broken down into small parts so that it is easy to read and maintain
-The use of a map to show the player's location
-You have put a lot of effort into the UI and styling, and it shows
-Excellent job showing the direction arrows in the appropriate places on the screen
Overall, a really well done project! 🎉
| import styled from 'styled-components/macro'; | ||
|
|
||
| const BACKGROUND_IMAGES = { | ||
| '0,0': './images/backgroundImages/ScreenTwo.jpg', |
| tabIndex={0} | ||
| direction | ||
| onClick={onClick} | ||
| onKeyDown={onKeyDown}>{Icon && <Icon />} |
There was a problem hiding this comment.
Nice job including the onKeyDown
| @@ -0,0 +1,37 @@ | |||
| import styled from 'styled-components'; | |||
|
|
|||
| export const Button = styled.button` | |||
There was a problem hiding this comment.
Really good work with using a reusable button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://labyrinth-project-week-12.netlify.app/
made by Jennifer and Nora