W12-Labyrinth by Maja-Zimnoch & Ylva-Karlsson#200
Open
YlvaKarlsson wants to merge 14 commits intoTechnigo:masterfrom
Open
W12-Labyrinth by Maja-Zimnoch & Ylva-Karlsson#200YlvaKarlsson wants to merge 14 commits intoTechnigo:masterfrom
YlvaKarlsson wants to merge 14 commits intoTechnigo:masterfrom
Conversation
Co-authored-by: majazimnoch <majazimnoch@users.noreply.github.com>
| "eslint-plugin-react": "^7.30.1", | ||
| "eslint-plugin-react-hooks": "^4.6.0", | ||
| "lottie-react": "^2.4.0", | ||
| "nes.css": "^2.3.0", |
There was a problem hiding this comment.
Did you use this for this project? It's a cool feature!
|
|
||
| const onFormSubmit = (event) => { | ||
| event.preventDefault(); | ||
| dispatch(labyrinth.actions.setUserName(`${uuidv4()}/${usernameInputValue}`)); |
There was a problem hiding this comment.
You could also add this in your reducer, and then you would not need to use the uuidv4 and/or uuidv5: ```
setUsername: (state, action) => {
state.username = ${new Date().getTime()}+${action.payload}
},
| useEffect(() => { | ||
| setLoading(isLoading); | ||
| }, [isLoading]); | ||
| return ( |
There was a problem hiding this comment.
To control the duration of the animation, we added this code after the last dispatch in our thunk(s):
setTimeout(() => { dispatch(loading.actions.setLoading(false)) }, 1500). You can also put the speed at 1.0 to slow your animation down a bit more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://w12-labyrinth-by-maja-and-ylva.netlify.app/