Open
Conversation
…he server.js file
HIPPIEKICK
approved these changes
Dec 10, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Good job Johanna! Just remember going forward to make use of query params instead of creating different endpoints to filter.
Comment on lines
+35
to
+39
| app.get("/elves/all", (request, response) => { | ||
|
|
||
| // Return all elves | ||
| response.json(elves); | ||
| }); |
Contributor
There was a problem hiding this comment.
Hehe love the dataset! A more RESTful approach would be to name this endpoint just /elves and then have different query params to use as filters, e.g.
/elves?top-twelves=true
/elves?title=backend dasher
Comment on lines
+86
to
+89
| app.get("/test", (request, response) => { | ||
| response.send("Jingle bells, the server tells, it's up and running well!"); | ||
| console.log("Jingle bells, the server tells, it's up and running well!"); | ||
| }); |
Comment on lines
+71
to
+80
| app.get("/elves/:id", (request, response) => { | ||
| const id = request.params.id; | ||
|
|
||
| const elf = elves.find((record) => record.elfID === +id); | ||
| if (elf) { | ||
| response.status(200).json(elf); | ||
| } else { | ||
| response.status(404).send("404 - No elf found with that ID"); | ||
| } | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View it live here