Conversation
HIPPIEKICK
approved these changes
Sep 19, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Great job on completing this project! 🎉 Let's have a look at some feedback.
JavaScript
- Your functions are well structured! Just be mindful of the order when using arrow functions. Have a look at last week's Zoom Recordings page.
- Good usage of conditionals ⭐
Clean Code
- Try to be consistent with your function naming, i.e. they should be named after what they are doing. Also, they should be named using camelCase (starting with lowercase letter)
- Be consistent with whether you're using double or single quotes
Keep up the good work! 💯
Comment on lines
+183
to
+186
| inputWrapper.style.display = 'flex'; | ||
| inputWrapper.style.width = '100%'; | ||
| inputWrapper.style.boxSizing = 'border-box'; | ||
| inputWrapper.style.padding = '10px'; |
Contributor
There was a problem hiding this comment.
This could maybe be refactored 👀
|
What a fun and nice chatbot you have created @Fannyhenriques! 🎬 An extra plus for the end reply as well "Grab your popcorn!" 🍿😄 The chat bot functions works well and it is easy to follow the flow. I also find your code easy to read. Suggestions of improvement: As Matilda already mentioned, be consistent with using camelCase for your functions. (lowercaseUppercase) Example below;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://moviechatbot.netlify.app/