Open
Conversation
HIPPIEKICK
approved these changes
Sep 18, 2024
Contributor
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Great job on your chatbot project! 🍪 Let's go over each part of your code for more specific feedback and suggestions.
HTML/CSS
- Well-structured HTML and nicely styled with CSS ⭐
JavaScript
- The code is broken into functions, which is an excellent practice. Functions like goodbyeMessage, handleConfirmationChoice, and createConfirmationButtons are modular ⭐ By just reading what they are named, I understand what they are doing, so kudos on good naming as well! Just a tiny thing - to be even more conforming, you could change the goodbyeMessage function to be called sayGoodbye or sendGoodbyeMessage (so that it's named in verb form as the other functions 😄)
- Consider adding basic input validation before processing user input (e.g., checking if the input field is empty before handling a form submission).
- Fun addition with sound 🔈
Clean Code
- Remember that everything should be in English (comments in this case)
- Remember to remove unused code
- Some class names could be more descriptive. For example, monster-picture and monster-picture2 could be named more contextually based on their usage (e.g., cookie-monster-main).
- Again - really good function names overall ⭐
Keep up the good work ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://cookiebot-lifeisbetterwithcookies.netlify.app/