Harmoniqa – The soundtrack to your mood#280
Open
HeleneWestrin wants to merge 19 commits intoTechnigo:mainfrom
Open
Harmoniqa – The soundtrack to your mood#280HeleneWestrin wants to merge 19 commits intoTechnigo:mainfrom
HeleneWestrin wants to merge 19 commits intoTechnigo:mainfrom
Conversation
HIPPIEKICK
approved these changes
Sep 18, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Very nice idea for a chatbot 🎵 Let's have a look at some feedback 👇
HTML/CSS
- Not much to say here, you kept it clean and structured 👍
- Nice use of CSS variables for colors (:root) to maintain a consistent theme and simplify future changes.
JavaScript
- Great use of constants for managing delays and selectors, making the code more maintainable and adjustable.
- Helper functions like getLatestMessage(), showMessage(), userMessage(), and botMessage() are well-defined
- The file is quite big which makes it a little bit difficult to overview. However, your comments help a lot and when we move over to React you will be able to make your code even more modular (splitting up components into different files).
- Nice usage of switch!
Keep up the good work 🥳
|
|
||
| document.getElementById("button-moody").addEventListener("click", () => { | ||
| colorSelection("Moody"); | ||
| inputWrapper.innerHTML = ""; // Remove the input area after user replies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
Harmoniqa »