You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, Ida :)
I checked out your backend, it looks beautiful! You’ve covered authentication, CRUD for thoughts, and even added nice extras like filtering, sorting, and pagination. The code is clear and well-structured, which makes it easy to follow. One small idea would be to split out routes and auth into separate files to keep things even more organized (I've got this tip from Jonny).
Since you already use bcrypt, you might switch the sync methods to async so the server doesn’t block. For example: const salt = await bcrypt.genSalt(10); const hashedPassword = await bcrypt.hash(password, salt);
I use the synchronous methods as you do. I've learned recently that it works fine for small projects, but Sync methods block the event loop (meaning that while one password is hashing, no other request can be processed).
The reason will be displayed to describe this comment to others. Learn more.
Really good job with this project!
You have nailed all requirements and stretch goals as well. You are approved with VG
Next step would be to refactor and break up the code into smaller chunks rather than having everything in the server.s file.
Looking forward to see you final project!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include your Render link here.
https://fantastic-cheesecake-0fb0f0.netlify.app/