Skip to content

Fix: Projects timelog - Billable should always be optional #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaeljusto merged 1 commit into from
Jun 22, 2026
+4 −6
Merged

Fix: Projects timelog - Billable should always be optional #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ require (
github.com/modelcontextprotocol/go-sdk v1.6.1
github.com/teamwork/desksdkgo v1.0.1
github.com/teamwork/spacessdkgo v0.0.0-20260518181558-a6af69d00abb
github.com/teamwork/twapi-go-sdk v1.19.2
github.com/teamwork/twapi-go-sdk v1.19.3
)

require (
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ github.com/teamwork/desksdkgo v1.0.1 h1:Mi5D1pnGfL5JwD7s7g7OyHml7Y9jsak5MNJaotJt
github.com/teamwork/desksdkgo v1.0.1/go.mod h1:Mgvw83q8iqHr7Sm9xV1iI/T89o3ObaPU3ChMJheRzwA=
github.com/teamwork/spacessdkgo v0.0.0-20260518181558-a6af69d00abb h1:bQluDjySZeC5etnWgjk4WFRy0PvzGDw8XEBd4JJYWCQ=
github.com/teamwork/spacessdkgo v0.0.0-20260518181558-a6af69d00abb/go.mod h1:jfE0RLsZuk/3Glzs5bJ95pNb92emV7uXZYgoGSLQ76I=
github.com/teamwork/twapi-go-sdk v1.19.2 h1:44RXG4Q0mFobfheB2338MX5xjN8imNP7rig+BtivCf8=
github.com/teamwork/twapi-go-sdk v1.19.2/go.mod h1:Z0R6uOeso0BH1tKdHVbT5TOqVGPMwPLuTPsHSyl4G/8=
github.com/teamwork/twapi-go-sdk v1.19.3 h1:kR02Y6tZPeV6/0Rsi00r0HYUHYZPp59WV1+h2fBfdZ8=
github.com/teamwork/twapi-go-sdk v1.19.3/go.mod h1:Z0R6uOeso0BH1tKdHVbT5TOqVGPMwPLuTPsHSyl4G/8=
github.com/tinylib/msgp v1.6.3 h1:bCSxiTz386UTgyT1i0MSCvdbWjVW+8sG3PjkGsZQt4s=
github.com/tinylib/msgp v1.6.3/go.mod h1:RSp0LW9oSxFut3KzESt5Voq4GVWyS+PSulT77roAqEA=
github.com/tklauser/go-sysconf v0.3.16 h1:frioLaCQSsF5Cy1jgRBrzr6t502KIIwQ0MArYICU0nA=
Expand Down
4 changes: 1 addition & 3 deletions internal/twprojects/timelogs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ func TimelogCreate(engine *twapi.Engine) toolsets.ToolWrapper {
{Type: "boolean"},
{Type: "null"},
},
Default: []byte("false"),
},
"project_id": {
Description: "Project the timelog is logged against. Provide exactly one of project_id or task_id.",
Expand Down Expand Up @@ -151,7 +150,7 @@ func TimelogCreate(engine *twapi.Engine) toolsets.ToolWrapper {
helpers.OptionalParam(&timelogCreateRequest.IsUTC, "is_utc"),
helpers.RequiredNumericParam(&timelogCreateRequest.Hours, "hours"),
helpers.RequiredNumericParam(&timelogCreateRequest.Minutes, "minutes"),
helpers.OptionalParam(&timelogCreateRequest.Billable, "billable"),
helpers.OptionalPointerParam(&timelogCreateRequest.Billable, "billable"),
helpers.OptionalNumericPointerParam(&timelogCreateRequest.UserID, "user_id"),
helpers.OptionalNumericListParam(&timelogCreateRequest.TagIDs, "tag_ids"),
)
Expand Down Expand Up @@ -228,7 +227,6 @@ func TimelogUpdate(engine *twapi.Engine) toolsets.ToolWrapper {
{Type: "boolean"},
{Type: "null"},
},
Default: []byte("false"),
},
"project_id": {
Description: "Project the timelog is logged against. Provide exactly one of project_id or task_id.",
Expand Down