Fix: Update Get and List tasks schemas type overrides#361
Merged
Conversation
The twapi.Date JSON-schema override was inlined in the task get/list output schemas, but the same Task struct (with its twapi.Date startDate/ dueDate fields) is also sideloaded into the calendar event list and search responses, which were generating the wrong schema for those nested dates. Extract the override into a reusable helpers.WithDateTypeSchema option and apply it to all four response schemas: task get/list, calendar event list, and search. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rafaeljusto
approved these changes
Jun 22, 2026
rafaeljusto
left a comment
rafaeljusto
left a comment
Contributor
There was a problem hiding this comment.
Nice one! I've sent a patch to cover a few more places.
There's an ongoing discussion here that would simplify this solution:
google/jsonschema-go#78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add schema generation type override for
twapi.Datefor tasks Get and List responses.Connected to changes in twapi-go-sdk.
Description
Type of Change
Testing
go test -v ./...)Checklist