Fix: Generics - Upgrade dependency to correctly handle new AST types#99
Merged
rafaeljusto merged 1 commit intomasterfrom Feb 25, 2025
Merged
Fix: Generics - Upgrade dependency to correctly handle new AST types#99rafaeljusto merged 1 commit intomasterfrom
rafaeljusto merged 1 commit intomasterfrom
Conversation
Fix an error raised when trying to extract a tag name from a generic type.
```
panic: can't get name for &ast.IndexExpr{X:(*ast.SelectorExpr)(0x40001cb6b0), Lbrack:4887, Index:(*ast.SelectorExpr)(0x40001cb6c8), Rbrack:4914}
goroutine 1 [running]:
github.com/teamwork/kommentaar/vendor/github.com/teamwork/utils/v2/goutil.getEmbedName({0x642200?, 0x400018c1e0?})
/go/src/github.com/teamwork/kommentaar/vendor/github.com/teamwork/utils/v2/goutil/goutil.go:257 +0x108
github.com/teamwork/kommentaar/vendor/github.com/teamwork/utils/v2/goutil.TagName(0x4000001d40?, {0x559e40?, 0x5?})
/go/src/github.com/teamwork/kommentaar/vendor/github.com/teamwork/utils/v2/goutil/goutil.go:224 +0x44
github.com/teamwork/kommentaar/docparse.GetReference(0x4000001d40, {0x559e40, 0x5}, 0x0, {0x40006f813a, 0x11}, {0x40001706e0, 0x50})
/go/src/github.com/teamwork/kommentaar/docparse/find.go:440 +0x1088
github.com/teamwork/kommentaar/docparse.parseRefValue(0x4000001d40, {0x559e40, 0x5}, {0x40006f813a, 0x11}, {0x40001706e0, 0x50})
/go/src/github.com/teamwork/kommentaar/docparse/docparse.go:501 +0xc0
github.com/teamwork/kommentaar/docparse.parseComment(0x4000001d40, {0x40006f8000, 0x1c1}, {0x0?, 0x0?}, {0x40001706e0, 0x50})
/go/src/github.com/teamwork/kommentaar/docparse/docparse.go:274 +0x570
github.com/teamwork/kommentaar/docparse.FindComments({0x63e820, 0x400004a060}, 0x4000001d40)
/go/src/github.com/teamwork/kommentaar/docparse/find.go:49 +0x448
main.start()
/go/src/github.com/teamwork/kommentaar/main.go:91 +0x4f0
main.main()
/go/src/github.com/teamwork/kommentaar/main.go:23 +0x48
```
Pull Request Test Coverage Report for Build 13520171905Details
💛 - Coveralls |
shane-tw
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an error raised when trying to extract a tag name from a generic type.
Related to:
Teamwork/utils#85