Skip to content

Feature: Add support for generics#98

Merged
rafaeljusto merged 1 commit intomasterfrom
generics
Feb 25, 2025
Merged

Feature: Add support for generics#98
rafaeljusto merged 1 commit intomasterfrom
generics

Conversation

@rafaeljusto
Copy link
Contributor

Allow generating documentation for a generic type.

@rafaeljusto rafaeljusto requested a review from a team February 21, 2025 23:57
@rafaeljusto
Copy link
Contributor Author

Moving this back to draft as the final schema needs to be different.

@rafaeljusto rafaeljusto marked this pull request as draft February 22, 2025 11:03
@rafaeljusto rafaeljusto removed the request for review from a team February 22, 2025 11:03
Allow generating documentation for generic types.
@coveralls
Copy link

coveralls commented Feb 24, 2025

Pull Request Test Coverage Report for Build 13498598658

Details

  • 11 of 78 (14.1%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.8%) to 55.116%

Changes Missing Coverage Covered Lines Changed/Added Lines %
docparse/jsonschema.go 10 77 12.99%
Totals Coverage Status
Change from base Build 12279144155: -1.8%
Covered Lines: 1115
Relevant Lines: 2023

💛 - Coveralls

@rafaeljusto
Copy link
Contributor Author

The code was reworked to set the expected schema output. Ready for review.

@rafaeljusto rafaeljusto marked this pull request as ready for review February 24, 2025 12:59
@rafaeljusto rafaeljusto requested a review from a team February 24, 2025 12:59
Copy link
Contributor

@shane-tw shane-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👏

@rafaeljusto rafaeljusto merged commit 959384d into master Feb 25, 2025
3 checks passed
@rafaeljusto rafaeljusto deleted the generics branch February 25, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants