MT6589 USB Driver

Documentation/devicetree/bindings/mfd/syscon.yaml

@@ -84,8 +84,6 @@ select:
           - mediatek,mt2701-pctl-a-syscfg
           - mediatek,mt2712-pctl-a-syscfg
           - mediatek,mt6397-pctl-pmic-syscfg
-          - mediatek,mt6589-pctl-a-syscfg
-          - mediatek,mt6589-pctl-b-syscfg
           - mediatek,mt7988-topmisc
           - mediatek,mt8135-pctl-a-syscfg
           - mediatek,mt8135-pctl-b-syscfg
@@ -192,8 +190,6 @@ properties:
           - mediatek,mt2701-pctl-a-syscfg
           - mediatek,mt2712-pctl-a-syscfg
           - mediatek,mt6397-pctl-pmic-syscfg
-          - mediatek,mt6589-pctl-a-syscfg
-          - mediatek,mt6589-pctl-b-syscfg
           - mediatek,mt7988-topmisc
           - mediatek,mt8135-pctl-a-syscfg
           - mediatek,mt8135-pctl-b-syscfg

Documentation/devicetree/bindings/phy/mediatek,tphy.yaml

@@ -71,6 +71,7 @@ properties:
       - items:
           - enum:
               - mediatek,mt2701-tphy
+              - mediatek,mt6589-tphy
               - mediatek,mt7623-tphy
               - mediatek,mt7622-tphy
               - mediatek,mt8516-tphy

Documentation/devicetree/bindings/pinctrl/mediatek,mt6589-pinctrl.yaml

@@ -0,0 +1,148 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/mediatek,mt6589-pinctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT6589 Pin Controller
+
+maintainers:
+  - Akari Tsuyukusa <akkun11.open@gmail.com>
+
+description:
+  The MediaTek pin controller on MT6589 is used to control pin functions, pull
+  up/down resistance and drive strength options.
+
+properties:
+  compatible:
+    enum:
+      - mediatek,mt6589-pinctrl
+
+  reg:
+    minItems: 3
+    maxItems: 3
+    description: Physical addresses for GPIO base(s) and EINT registers.
+
+  reg-names:
+    items:
+      - const: gpio
+      - const: gpio1
+      - const: eint
+
+  gpio-controller: true
+
+  "#gpio-cells":
+    const: 2
+    description:
+      Number of cells in GPIO specifier. Since the generic GPIO binding is used,
+      the amount of cells must be specified as 2. See the below mentioned gpio
+      binding representation for description of particular cells.
+
+  gpio-ranges:
+    minItems: 1
+    maxItems: 5
+    description:
+      GPIO valid number range.
+
+  interrupt-controller: true
+
+  interrupts:
+    maxItems: 1
+    description:
+      Specifies the summary IRQ.
+
+  "#interrupt-cells":
+    const: 2
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - gpio-controller
+  - "#gpio-cells"
+  - interrupts
+  - interrupt-controller
+  - "#interrupt-cells"
+
+patternProperties:
+  '-[0-9]*$':
+    type: object
+    additionalProperties: false
+
+    patternProperties:
+      '-pins*$':
+        type: object
+        description:
+          A pinctrl node should contain at least one subnodes representing the
+          pinctrl groups available on the machine. Each subnode will list the
+          pins it needs, and how they should be configured, with regard to muxer
+          configuration, pullups, drive strength, input enable/disable and input
+          schmitt.
+        $ref: /schemas/pinctrl/pincfg-node.yaml
+
+        properties:
+          pinmux:
+            description:
+              Integer array, represents gpio pin number and mux setting.
+              Supported pin number and mux varies for different SoCs, and are
+              defined as macros in dt-bindings/pinctrl/<soc>-pinfunc.h directly.
+
+          bias-disable: true
+
+          bias-pull-up: true
+
+          bias-pull-down: true
+
+          input-enable: true
+
+          input-disable: true
+
+          output-low: true
+
+          output-high: true
+
+          input-schmitt-enable: true
+
+          input-schmitt-disable: true
+
+          drive-strength:
+            enum: [2, 4, 8, 10, 12, 14, 16, 20, 24, 28, 32]
+
+          slew-rate:
+            enum: [0, 1]
+
+          # TODO
+          mediatek,pull-up-adv:
+            description: |
+              Pull up settings for 2 pull resistors, R0 and R1. User can
+              configure those special pins. Valid arguments are described as
+              below:
+              0: (R1, R0) = (0, 0) which means R1 disabled and R0 disabled.
+              1: (R1, R0) = (0, 1) which means R1 disabled and R0 enabled.
+              2: (R1, R0) = (1, 0) which means R1 enabled and R0 disabled.
+              3: (R1, R0) = (1, 1) which means R1 enabled and R0 enabled.
+            $ref: /schemas/types.yaml#/definitions/uint32
+            enum: [0, 1, 2, 3]
+
+          mediatek,pull-down-adv:
+            description: |
+              Pull down settings for 2 pull resistors, R0 and R1. User can
+              configure those special pins. Valid arguments are described as
+              below:
+              0: (R1, R0) = (0, 0) which means R1 disabled and R0 disabled.
+              1: (R1, R0) = (0, 1) which means R1 disabled and R0 enabled.
+              2: (R1, R0) = (1, 0) which means R1 enabled and R0 disabled.
+              3: (R1, R0) = (1, 1) which means R1 enabled and R0 enabled.
+            $ref: /schemas/types.yaml#/definitions/uint32
+            enum: [0, 1, 2, 3]
+
+        required:
+          - pinmux
+
+        additionalProperties: false
+
+additionalProperties: false
+
+examples:
+  - |
+      TODO

Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml

@@ -18,7 +18,6 @@ properties:
       - mediatek,mt2701-pinctrl
       - mediatek,mt2712-pinctrl
       - mediatek,mt6397-pinctrl
-      - mediatek,mt6589-pinctrl
       - mediatek,mt7623-pinctrl
       - mediatek,mt8127-pinctrl
       - mediatek,mt8135-pinctrl

Documentation/devicetree/bindings/usb/mediatek,musb.yaml

@@ -19,6 +19,7 @@ properties:
       - enum:
           - mediatek,mt8516-musb
           - mediatek,mt2701-musb
+          - mediatek,mt6589-musb
           - mediatek,mt7623-musb
       - const: mediatek,mtk-musb
 

arch/arm/boot/dts/mediatek/mt6589-lenovo-blade-b8000-f.dts

@@ -3,9 +3,56 @@
  * Copyright (c) 2025 akku <akkun11.open@gmail.com>
  */
 
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pinctrl/mt6589-pinfunc.h>
+
 #include "mt6589-lenovo-blade.dtsi"
 
 / {
 	model = "Lenovo YOGA Tablet 10 (Wi-Fi)";
 	compatible = "lenovo,blade-b8000-f", "lenovo,blade", "mediatek,mt6589";
+
+	usb_vbus: regulator-usb {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+//		gpio = <&pio 130 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		// testing
+		regulator-boot-on;
+		regulator-always-on;
+	};
+};
+
+&pio {
+	usb_pins: usb-pins {
+		pins_iddig {
+			pinmux = <MT6589_PIN_57_GPIO57__FUNC_EINT34>;
+			input-enable;
+			bias-pull-up;
+		};
+	};
+};
+
+&usb0 {
+	status = "okay";
+//	usb-role-switch;
+//	dr_mode = "otg";
+	dr_mode = "peripheral";
+
+	// testing
+	//vbus-supply = <&usb_vbus>;
+/*
+	connector {
+		compatible = "gpio-usb-b-connector", "usb-b-connector";
+		type = "micro";
+		id-gpios = <&pio 57 GPIO_ACTIVE_HIGH>;
+		vbus-supply = <&usb_vbus>;
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&usb_pins>;
+	};
+*/
 };

arch/arm/boot/dts/mediatek/mt6589.dtsi

@@ -8,6 +8,7 @@
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/clock/mt6589-clk.h>
+#include <dt-bindings/phy/phy.h>
 
 / {
 	#address-cells = <1>;
@@ -143,17 +144,17 @@
 			#clock-cells = <1>;
 		};
 
-		/*
-		 * EINT registers: 0x1000b000
-		 * GPIO base: 0x10005000, GPIO1 base 0x1020c000
-		 */
 		pio: pinctrl@10005000 {
 			compatible = "mediatek,mt6589-pinctrl";
-			reg = <0x1000b000 0x1000>;
-			mediatek,pctl-regmap = <&syscfg_pctl_a &syscfg_pctl_b>;
+			reg = <0x10005000 0x1000>,
+			      <0x1020c000 0x1000>,
+			      <0x1000b000 0x1000>;
+			reg-names = "gpio", "gpio1", "eint";
 			gpio-controller;
 			#gpio-cells = <2>;
+			gpio-ranges = <&pio 0 0 232>;
 			interrupt-controller;
+			interrupt-parent = <&gic>;
 			#interrupt-cells = <2>;
 			interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
@@ -261,5 +262,64 @@
 			clock-names = "baud", "bus";
 			status = "disabled";
 		};
+
+		/* USB 2.0 */
+		usb0: usb@11200000 {
+			compatible = "mediatek,mt6589-musb",
+				     "mediatek,mtk-musb";
+			reg = <0x11200000 0x1000>;
+			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
+			interrupt-names = "mc";
+			phys = <&usb_port0 PHY_TYPE_USB2>;
+			dr_mode = "otg";
+			/* FIXME: clocks */
+			clocks = <&pericfg CLK_PERI0_USB0>,
+				 <&clk26m>,
+				 <&topckgen CLK_TOP_UNIVPLL_D26>;
+			clock-names = "main", "mcu", "univpll";
+			status = "disabled";
+		};
+
+		/* USB 1.1 */
+		usb1: usb@11210000 {
+			compatible = "mediatek,mt6589-musb",
+				     "mediatek,mtk-musb";
+			reg = <0x11210000 0x1000>;
+			interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_LOW>;
+			interrupt-names = "mc";
+			phys = <&usb_port1 PHY_TYPE_USB2>;
+			dr_mode = "otg";
+			clocks = <&pericfg CLK_PERI0_USB1>,
+				 <&clk26m>,
+				 <&topckgen CLK_TOP_UNIVPLL_D26>;
+			clock-names = "main", "mcu", "univpll";
+			status = "disabled";
+		};
+
+		u2phy0: t-phy@11220000 {
+			compatible = "mediatek,mt6589-tphy",
+				     "mediatek,generic-tphy-v1";
+			reg = <0x11220000 0x0800>;
+			ranges;
+			status = "okay";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			usb_port0: usb-phy@11220800 {
+				reg = <0x11220800 0x0100>;
+				clocks = <&topckgen CLK_TOP_UNIVPLL_D26>;
+				clock-names = "ref";
+				#phy-cells = <1>;
+				status = "okay";
+			};
+
+			usb_port1: usb-phy@11220900 {
+				reg = <0x11220900 0x0100>;
+				clocks = <&topckgen CLK_TOP_UNIVPLL_D26>;
+				clock-names = "ref";
+				#phy-cells = <1>;
+				status = "okay";
+			};
+		};
 	};
 };

arch/arm/configs/lenovo-blade_defconfig

@@ -87,14 +87,19 @@ CONFIG_PINCTRL_MT6589=y
 #CONFIG_DMADEVICES=y
 
 ## USB
+CONFIG_USB=y
 CONFIG_USB_SUPPORT=y
 CONFIG_USB_GADGET=y
-CONFIG_USB=y
+CONFIG_USB_CONFIGFS=y
 CONFIG_USB_MUSB_HDRC=y
 CONFIG_USB_MUSB_MEDIATEK=y
 CONFIG_NOP_USB_XCEIV=y
 CONFIG_USB_SERIAL=y
-#CONFIG_PHY_MTK_TPHY=y # is needed?
+CONFIG_PHY_MTK_TPHY=y
+# FIXME: DEBUG
+CONFIG_MUSB_PIO_ONLY=y
+CONFIG_USB_CONN_GPIO=y
+CONFIG_USB_GPIO_VBUS=y
 
 ## MMC (eMMC/SD)
 CONFIG_MMC=y
@@ -113,6 +118,10 @@ CONFIG_MMC_MTK=y
 ## Reset
 #CONFIG_RESET_CONTROLLER
 
+## Regulator
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_FIXED_VOLTAGE=y
+
 ## Battery
 
 ## Audio
@@ -122,6 +131,10 @@ CONFIG_MMC_MTK=y
 ## GPU
 #CONFIG_SGX=y # not ported
 
+## Networking
+CONFIG_NET=y
+CONFIG_USB_ETH=y
+
 ## Wi-Fi / Bluetooth
 
 ## Thermal
@@ -149,6 +162,7 @@ CONFIG_BLK_DEV_LOOP=y
 
 ### FS
 CONFIG_UNICODE=y
+CONFIG_DEBUG_FS=y
 CONFIG_EXT4_FS=y
 CONFIG_VFAT_FS=y
 # VFAT