add MT6320 driver by akku1139 · Pull Request #19 · TeamYogaBlade2/linux

akku1139 · 2026-01-03T02:14:33Z

akku1139 · 2026-01-18T15:42:08Z

needed to add WRAP_WR32(PMIC_WRAP_HIPRIO_ARB_EN,8); ?
https://github.com/bq/aquaris-5/blob/bc1d0d0e35c969670e2d869001be944ad0c9c5e5/mediatek/platform/mt6589/kernel/drivers/pmic_wrap/pwrap_hal.c#L896C3-L896C40
(Enable WACS2)

linux/drivers/soc/mediatek/mtk-pmic-wrap.c

Line 2118 in aea15fa

pwrap_writel(wrp, 0x1, PWRAP_WACS2_EN);

akku1139 · 2026-01-18T16:09:09Z

registers
https://github.com/bq/aquaris-5/blob/aquaris-5/mediatek/platform/mt6589/kernel/drivers/pmic_wrap/pwrap_hal.h

akku1139 · 2026-01-18T16:12:49Z

same

https://github.com/torvalds/linux/blob/e84d960149e71e8d5e4db69775ce31305898ed0c/drivers/soc/mediatek/mtk-pmic-wrap.c#L20-L28

https://github.com/bq/aquaris-5/blob/bc1d0d0e35c969670e2d869001be944ad0c9c5e5/mediatek/platform/mt6589/kernel/drivers/pmic_wrap/pwrap_hal.h#L230-L253

because MT6589 also have these registers

MT6589 and MT8135 have PWRAP bridge registers with the same name and address.

The unique registers of MT8135 are the same as those of MT6589, so they have been made common. PWRAP_DVFS_ADR0 to PWRAP_DVFS_WDATA7 were in the MT8173 part, but these registers are used in many SoCs, not just the MT6589.

based on: https://github.com/bq/aquaris-5/blob/bc1d0d0e35c969670e2d869001be944ad0c9c5e5/mediatek/platform/mt6589/kernel/core/include/mach/mt_pmic.h#L56-L549

akku1139 · 2026-02-26T09:49:40Z

omitted clock logic PMIC_TOP_CKCON2

05ca408

https://github.com/bq/aquaris-5/blob/bc1d0d0e35c969670e2d869001be944ad0c9c5e5/mediatek/platform/mt6589/kernel/drivers/pmic_wrap/pwrap_hal.c#L718-L734

https://github.com/djkurtz/chromiumos-third_party-kernel-mediatek/blob/3b4ee0da3c0fdab1c8a340bc055c96336d71d9e1/drivers/mfd/mt8135-pmic-wrap.c#L383-L396

akku1139 · 2026-02-26T13:48:12Z

MT6320's CID is duplicated!

linux/include/linux/mfd/mt6397/core.h

Lines 13 to 24 in d679e00

    
           enum chip_id { 
        
           	MT6323_CHIP_ID = 0x23, 
        
           	MT6328_CHIP_ID = 0x30, 
        
           	MT6331_CHIP_ID = 0x20, 
        
           	MT6332_CHIP_ID = 0x20, 
        
           	MT6357_CHIP_ID = 0x57, 
        
           	MT6358_CHIP_ID = 0x58, 
        
           	MT6359_CHIP_ID = 0x59, 
        
           	MT6366_CHIP_ID = 0x66, 
        
           	MT6391_CHIP_ID = 0x91, 
        
           	MT6397_CHIP_ID = 0x97, 
        
           };

//==============================================================================
// PMIC6320 Define
//==============================================================================
#define PMIC6320_E1_CID_CODE    0x1020
#define PMIC6320_E2_CID_CODE    0x2020

https://github.com/bq/aquaris-5/blob/bc1d0d0e35c969670e2d869001be944ad0c9c5e5/mediatek/platform/mt6589/kernel/core/include/mach/mt\_pmic.h#L6-L10

akku1139 · 2026-02-26T18:30:32Z

drivers/mfd/mt6397-irq.c: In function 'mt6397_irq_init':
drivers/mfd/mt6397-irq.c:201:9: error: duplicate case value
  201 |         case MT6331_CHIP_ID:
      |         ^~~~
drivers/mfd/mt6397-irq.c:181:9: note: previously used here
  181 |         case MT6320_CHIP_ID:
      |         ^~~~

CIDs set for MT6328, MT6331 and MT6332 are not appropriate. Many Android downstream kernels define CID as below, MT6328: #define PMIC6328_E1_CID_CODE 0x2810 #define PMIC6328_E2_CID_CODE 0x2820 #define PMIC6328_E3_CID_CODE 0x2830 MT6331/MT6332: #define PMIC6331_E1_CID_CODE 0x3110 #define PMIC6331_E2_CID_CODE 0x3120 #define PMIC6331_E3_CID_CODE 0x3130 #define PMIC6332_E1_CID_CODE 0x3210 #define PMIC6332_E2_CID_CODE 0x3220 #define PMIC6332_E3_CID_CODE 0x3230 The current configuration incorrectly uses the revision code as the CID. Therefore, the driver cannot detect the same PMIC of different revisions. (E1/E2 for MT6328, E1/E3 for MT6331/MT6332) Based on these, the CID of MT6328, MT6331 and MT6332 should be corrected. Additionally, the incorrect MT6331/MT6332 CID overlaps with the MT6320's actual CID: #define PMIC6320_E1_CID_CODE 0x1020 #define PMIC6320_E2_CID_CODE 0x2020 This causes a conflict in the switch-case statement of mt6397-irq.c, this prevents adding support for MT6320. Link: https://github.com/parthibx24/android_kernel_mediatek_k35/blob/4853d1fd9e40563573fa6d6b32b75d571a95e2b7/drivers/misc/mediatek/power/mt6735/pmic.h#L10-L12 Link: https://github.com/meizuosc/m75/blob/80ef1d26c5d73e131d064138ed09ff5a2be2bed8/mediatek/platform/mt6595/kernel/core/include/mach/pmic_mt6331_6332_sw.h#L9-L15 Link: https://github.com/toffyjan/android_Ticwatch_S_mooneye/blob/4f2a73b26f3821afc452cdce660cdbc73daf4e4a/arch/arm/mach-mt2601/include/mach/pmic_mt6320_sw.h#L29-L30 Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com>

akku1139 · 2026-03-01T15:07:10Z

https://github.com/bq/aquaris-5/blob/bc1d0d0e35c969670e2d869001be944ad0c9c5e5/mediatek/platform/mt6589/kernel/core/include/mach/pmic_mt6320_sw.h
https://github.com/bq/aquaris-5/blob/bc1d0d0e35c969670e2d869001be944ad0c9c5e5/mediatek/platform/mt6589/kernel/drivers/power/pmic_mt6320.c
https://github.com/TeamYogaBlade2/note/wiki#pmic
https://github.com/TeamYogaBlade2/note/wiki/PMIC

akku1139 · 2026-03-03T12:14:05Z

https://github.com/bq/aquaris-E4.5/blob/34cf494bca625acad06274c3cba10aca148813c0/mediatek/platform/mt6582/kernel/drivers/power/pmic_mt6323.c#L5

akku1139 · 2026-03-03T12:47:11Z

https://github.com/guruprasadah/android_kernel_mt8512_echo4thgen/blob/9eabe01520f023ec0bb1f8fade2e6f8576360900/drivers/misc/mediatek/include/mt-plat/mt8512/include/mach/upmu_sw.h#L36

akku1139 · 2026-03-03T12:54:36Z

upmu_set_rg_*()

https://github.com/bq/aquaris-5/blob/bc1d0d0e35c969670e2d869001be944ad0c9c5e5/mediatek/platform/mt6589/kernel/drivers/power/upmu_common.c

or mediatek/platform/mt6589/lk/mt_pmic.c

pinctrl: mediatek: init mt6320 driver

08fa6db

akku1139 marked this pull request as draft January 3, 2026 02:43

akku1139 added 6 commits January 18, 2026 19:04

dt-bindings: soc: mediatek: pwrap: Add compatible for MT6589 SoC

2c78263

arm: dts: mediatek: mt6589: add pwrap node

b6f885a

arm: dts: mediatek: mt6589: add pwrap reset

911359f

arm: dts: mediatek: mt6589: add pwrap-bridge reset

a5e8252

wip: soc: mediatek: pwrap: add mt6589 support

c54f917

wip: soc: mediatek: pwrap: fix mt6589

cc4d0a0

akku1139 added 2 commits January 19, 2026 00:44

wip: soc: mediatek: pwrap: mt6589 and mt6320 porting

a845b14

wip: soc: mediatek: pwrap: add mt6320 regs

1e6d174

akku1139 added 15 commits January 19, 2026 01:17

wip: soc: mediatek: pwrap: add mt6589 regs

8458e12

soc: mediatek: pwrap: rename PWRAP_MT8135_BRIDGE_* to PWRAP_BRIDGE_*

72a1f8e

because MT6589 also have these registers

soc: mediatek: pwrap: fix dew_regs for MT6589

49e6c51

soc: mediatek: pwrap: add more PERI_PWRAP_BRIDGE registers

f9b9262

MT6589 and MT8135 have PWRAP bridge registers with the same name and address.

soc: mediatek: pwrap: fix pwrap_regs for MT6589

046664d

The unique registers of MT8135 are the same as those of MT6589, so they have been made common. PWRAP_DVFS_ADR0 to PWRAP_DVFS_WDATA7 were in the MT8173 part, but these registers are used in many SoCs, not just the MT6589.

soc: mediatek: pwrap: mt6589 cleanup

0b6b334

soc: mediatek: pwrap: fix MT6320 regops

7142f92

mfd: mt6320: add register index

e238dad

based on: https://github.com/bq/aquaris-5/blob/bc1d0d0e35c969670e2d869001be944ad0c9c5e5/mediatek/platform/mt6589/kernel/core/include/mach/mt_pmic.h#L56-L549

arm: dts: mediatek: mt6589-lenovo-blade: add pmic

52a07f0

dt-bindings: soc: mediatek: pwrap: PMIC peripherals for MT6589

67fcd4e

dt-bindings: mfd: mediatek: add MT6320 binding

b9265fc

arm: configs: lenovo-blade: enable PWAP

b4004a1

soc: mediatek: fix mt6589/mt6320

05ca408

clk: mediatek: reindex mt6589 clocks

9d5dee8

dt-bindings: mfd: mediatek: move mt6320

d679e00

akku1139 added 6 commits February 27, 2026 03:16

mdf: rtc-mt6397: add mt6320 support

7c6f2a5

dt-bindings: input: mediatek,pmic-keys: add mediatek,mt6320-keys

c57f9c8

mfd: mt6397-core: add mt6320-keys

1f6430e

arm: dts: mediatek: mt6589-lenovo-blade: add mt6320keys

c3159b5

mfd: mt6320: fix syntax

547bba0

mfd: mt6397-core: fix mt6320 rtc

f4139ca

akku1139 added 15 commits March 1, 2026 19:06

mfd: mt6320: fix

b11ebef

arm: dts: mediatek: split mt6320

d74dd63

arm: dts: mediatek: mt6320: add license header

ba8d029

arm: configs: lenovo-blade: add CONFIG_POWER_RESET_MT6323

c75adc7

arm: dts: mediatek: mt6320: fix fix

7a5bac5

Merge remote-tracking branch 'origin/blade/v6.16' into dev/v6.16/mt6320

f592f9d

arm: dts: mediatek: mt6320: fix fix fix

33ce716

arm: configs: lenovo-blade: add CONFIG_PINCTRL_MT6320

6e580ea

pinctrl: mt6320: Add pinfunc header file for mt6320

fddb922

dt-bindings: mfd: mt6397: add mediatek,mt6320-regulator

f8318a5

mfd: mt6397-core: add mt6320-regulator

68acf06

arm: configs: lenovo-blade: add needed

f75e7b4

Input: mtk-pmic-keys: add mt6320 support

cf91e1b

WIP: MT6320 regulator

4c6828e

akku1139 added 4 commits March 2, 2026 01:01

regulator: mt6320: add header

755098c

regulator: mt6320: replace based on mt6323

c89aefb

wip: regulator: mt6320: early porting

a727b15

regulator: mt6320: todo note

b691632

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add MT6320 driver#19

add MT6320 driver#19
akku1139 wants to merge 60 commits intoblade/v6.16from
dev/v6.16/mt6320

akku1139 commented Jan 3, 2026 •

edited

Loading

Uh oh!

akku1139 commented Jan 18, 2026 •

edited

Loading

Uh oh!

akku1139 commented Jan 18, 2026

Uh oh!

akku1139 commented Jan 18, 2026

Uh oh!

akku1139 commented Feb 26, 2026 •

edited

Loading

Uh oh!

akku1139 commented Feb 26, 2026 •

edited

Loading

Uh oh!

akku1139 commented Feb 26, 2026

Uh oh!

akku1139 commented Mar 1, 2026 •

edited

Loading

Uh oh!

akku1139 commented Mar 3, 2026

Uh oh!

akku1139 commented Mar 3, 2026

Uh oh!

akku1139 commented Mar 3, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

akku1139 commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akku1139 commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akku1139 commented Jan 18, 2026

Uh oh!

akku1139 commented Jan 18, 2026

Uh oh!

akku1139 commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akku1139 commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akku1139 commented Feb 26, 2026

Uh oh!

akku1139 commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akku1139 commented Mar 3, 2026

Uh oh!

akku1139 commented Mar 3, 2026

Uh oh!

akku1139 commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

akku1139 commented Jan 3, 2026 •

edited

Loading

akku1139 commented Jan 18, 2026 •

edited

Loading

akku1139 commented Feb 26, 2026 •

edited

Loading

akku1139 commented Feb 26, 2026 •

edited

Loading

akku1139 commented Mar 1, 2026 •

edited

Loading

akku1139 commented Mar 3, 2026 •

edited

Loading