#001 디스코드 데일리 스크럼 봇을 생성한다 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmwhiten
commented
Aug 20, 2021
src/dailyScrum.js
Outdated
| exports.handler = async (event) => { | ||
|
|
||
| try { | ||
| const result = await axios.post("https://discord.com/api/webhooks/878293255857524826/pN3oIaw_rzUpPzJuaXui8nbwPH_YTfQyckHjjZOttU9S0JGZYrkX9u86giNEojIn0S9g", { |
Member
Author
There was a problem hiding this comment.
웹 훅 url이 공개되었네요 !!! 이런상황 매우 위험 ...... 수정해야겠따
Member
Author
There was a problem hiding this comment.
새로운 웹 훅을 만들어서 요거는 이제 유효하지 않아 놔두겠습니다!
이런 상황에는 dotenv라는 걸 사용하면 됩니다
Member
Author
|
혹시 어떻게 만드는지 궁금하다면 ~~~ ! 매우 간단하지만 스몰 세션을 열 수도 있습니당. 필요하다면 요청해주세용~! |
Member
당장해주세요~~ |
GyuhoLee
approved these changes
Aug 22, 2021
Comment on lines
+17
to
+21
| // TODO implement | ||
| const response = { | ||
| statusCode: 200, | ||
| body: JSON.stringify('daily scrum message from Lambda!'), | ||
| }; |
Member
There was a problem hiding this comment.
TODO implement는 생략하고,
try catch를 통해 error를 잡았는데 응답코드는 항상 200이 되는게 아닌가 싶어요
Member
Author
There was a problem hiding this comment.
오호 ~~ 반영해서 수정하도록 하겠습니당. 리뷰감사합니다~~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
#1 디스코드 데일리 스크럼 봇을 생성한다
Description
#데일리스크럼채널에 스크럼 메시지를 보냅니다.https://www.youtube.com/watch?v=i31QsZro6s0&lc=UgxjTnUXiFfIpHsJHZF4AaABAg.9IZ-Y0ZzcY09IZHBpE3Mc4
https://daje0601.tistory.com/73