Skip to content

Fix content range for itag-18 #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t6fb3m59 wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −9
Open

Fix content range for itag-18 #457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a833be0
fix(range): use clen query param as total file size, not upstream Con…
May 26, 2026
17d9f41
style(range): shorten Content-Range fix comment
May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ fn parse_range(range_str: &str, total_size: u64) -> Option<RangeRequest> {
fn handle_range_response_correction(
response: &mut HttpResponseBuilder,
range_str: Option<&String>,
clen: Option<u64>,
resp: &reqwest::Response,
) -> Option<()> {
// Check if this is a range request (either in headers or query string)
Expand All @@ -224,14 +225,19 @@ fn handle_range_response_correction(
return None;
}

// Get content length from response headers
let total_size = resp
.headers()
.get("content-length")?
.to_str()
.ok()?
.parse::<u64>()
.ok()?;
// total_size is the full file size from the videoplayback URL's `clen`. The
// upstream Content-Length is only the current chunk; using it as the total
// produced malformed Content-Range that broke itag-18 seek in Chromium.
let total_size = match clen {
Some(c) if c > 0 => c,
_ => resp
.headers()
.get("content-length")?
.to_str()
.ok()?
.parse::<u64>()
.ok()?,
};

if total_size == 0 {
return None;
Expand Down Expand Up @@ -483,7 +489,7 @@ async fn index(req: HttpRequest) -> Result<HttpResponse, Box<dyn Error>> {

// Fix range request handling - convert 200 to 206 if we have a range request
// and ensure Content-Range header is present
handle_range_response_correction(&mut response, range.as_ref(), &resp);
handle_range_response_correction(&mut response, range.as_ref(), clen, &resp);

if rewrite {
if let Some(content_type) = resp.headers().get("content-type") {
Expand Down