Open
Conversation
TobiGr
added
bug
TobiGr
force-pushed
the
mediaCCC/liveStream
branch
from
d556c84 to
62699e5
Compare
litetex
reviewed
Dec 27, 2021
TobiGr
changed the title
TobiGr
force-pushed
the
mediaCCC/liveStream
branch
from
62699e5 to
124a9e1
Compare
litetex
reviewed
Dec 27, 2021
The API was slightly changed and only HLS streams are provided anymore. Add a basic test for to check whether the required streamInfo fields are available. Closes #766
TobiGr
force-pushed
the
mediaCCC/liveStream
branch
from
124a9e1 to
752825c
Compare
Stypox
requested changes
Dec 30, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you! Could you provide an apk?
Comment on lines
+184
to
+187
| if (streamInfo.videoStreams.isEmpty() | ||
| && streamInfo.audioStreams.isEmpty() | ||
| && isNullOrEmpty(streamInfo.getHlsUrl()) | ||
| && isNullOrEmpty(streamInfo.getDashMpdUrl())) { |
Member
There was a problem hiding this comment.
Mmmh, I think before only videoStreams and audioStreams were checked because in any other case the stream is a livestream. So NewPipe's player expected to need to use hls/dash urls only on livestreams. Does this change break that workflow, or is the check being done differently by NewPipe and so this is not an issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API was slightly changed and only HLS streams are provided anymore.
Add a basic test for to check whether the required streamInfo fields are available.
Fixes #766