Skip to content

CMake: set required C++ standard via target_compile_features()#18

Merged
geneotech merged 1 commit intoTeamHypersomnia:masterfrom
lyorig:cmake_standard_via_target
Oct 14, 2025
Merged

CMake: set required C++ standard via target_compile_features()#18
geneotech merged 1 commit intoTeamHypersomnia:masterfrom
lyorig:cmake_standard_via_target

Conversation

@lyorig
Copy link
Copy Markdown
Contributor

@lyorig lyorig commented Oct 14, 2025

Currently, rectpack2D/CMakeLists.txt doesn't really communicate what C++ standard version it requires, there's only a set_properties() call in example/CMakeLists.txt that applies to the example executable itself. This is a minor edit that follows the build system's "best practices" and applies a required version to rectpack2D::rectpack2D that CMake (and perhaps other build systems like Meson) can better understand and work with.

@geneotech geneotech merged commit 4fe33b2 into TeamHypersomnia:master Oct 14, 2025
6 checks passed
@lyorig lyorig deleted the cmake_standard_via_target branch October 14, 2025 15:48
@lyorig
Copy link
Copy Markdown
Contributor Author

lyorig commented Oct 14, 2025

Now that I see "initial" as the most recent commit in both the src and example directory, I should've probably picked a more descriptive name for the commit... sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants