infoコマンドのサブコマンドをchoicesに変更#45
Open
yuu1111 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/infoのサジェストが about/oss/work の3行で表示されサジェスト一覧を圧迫していたため、SubcommandDataをOptionType.STRING+addChoiceに置き換え/infoサジェストが1行に集約され、typeパラメータで about/oss/work を選択する形になるevent.getSubcommandName()からevent.getOption("type").getAsString()に変更Test plan
/infoのサジェストが1行のみ表示されることを確認/info type:BOT情報で about の Embed が表示されることを確認/info type:OSSクレジットで oss の Embed が表示されることを確認/info type:稼働情報で work の Embed が表示されることを確認