GenericCopyUtil improvements#4577
Open
TranceLove wants to merge 2 commits intoTeamAmaze:release/4.0from
Open
Conversation
TranceLove
force-pushed
the
feature/generic-copy-util-improvements
branch
from
a123ebc to
0cb5abf
Compare
There was a problem hiding this comment.
Pull request overview
This PR modernizes GenericCopyUtil by migrating it (and its tests) from Java to Kotlin, while improving copy robustness/performance via larger transfer quanta and batched progress callbacks. It also replaces deprecated JUnit @Theory-based tests with explicit Kotlin test cases and adds new coverage for cancellation and progress batching.
Changes:
- Replaced
GenericCopyUtilJava implementation with a Kotlin version usingFileChannel.transferTofor file-to-file copies and batched progress updates. - Replaced Java unit/instrumentation tests with Kotlin tests (no deprecated
@Theory), adding more scenarios (empty file, cancellation, batching). - Increased transfer buffer quantum (1MB) for OTG/DocumentFile paths and channel-based copies.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt | Kotlin rewrite; adds transferTo fast path + progress batching + 1MB transfer quantum. |
| app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.java | Removes old Java implementation. |
| app/src/test/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilTest.kt | New Robolectric unit tests replacing @Theory, adding batching/cancellation coverage. |
| app/src/test/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilTest.java | Removes old Java unit tests. |
| app/src/androidTest/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilEspressoTest.kt | New instrumented tests in Kotlin, including batching/cancellation scenarios. |
| app/src/androidTest/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilEspressoTest.java | Removes old Java instrumented tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilEspressoTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilEspressoTest.kt
Outdated
Show resolved
Hide resolved
TranceLove
force-pushed
the
feature/generic-copy-util-improvements
branch
5 times, most recently
from
0368390 to
df0d36d
Compare
EmmanuelMess
requested changes
Mar 20, 2026
Member
EmmanuelMess
left a comment
EmmanuelMess
left a comment
There was a problem hiding this comment.
There are quite a few !!, please deal with them or provide an explanation for the ones left.
TranceLove
force-pushed
the
feature/generic-copy-util-improvements
branch
from
df0d36d to
cf15948
Compare
TranceLove
force-pushed
the
feature/generic-copy-util-improvements
branch
from
cf15948 to
db8bbe2
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/test/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/amaze/filemanager/filesystem/files/GenericCopyUtilTest.kt
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Show resolved
Hide resolved
TranceLove
force-pushed
the
feature/generic-copy-util-improvements
branch
from
db8bbe2 to
c489d0d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.kt
Show resolved
Hide resolved
TranceLove
force-pushed
the
feature/generic-copy-util-improvements
branch
from
c489d0d to
c0b97ce
Compare
- Convert to Kotlin - More tests - Bigger buffer size for copy from/to OTG storage
TranceLove
force-pushed
the
feature/generic-copy-util-improvements
branch
from
c0b97ce to
20b55ac
Compare
VishnuSanal
added
the
PR-Awaiting-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@Theoryin testsAutomatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck