Open
Conversation
bn-rBD eu-rES sv-rSE is-rIS ta-rIN
The values-ku is an ambiguous lang code. It should be one of ckb, kmr, sdh. But the translation file itself has only one string translated so it would be easier to just remove it
There is only Color that in GB is written as Colour. All other strings are the same as in en-US. It would be better to remove them because if the source string was changed then users in the en-GB locale will see an old string. In the same time if there is no a translation for a string then anyway it will be fall back to en-US
Contributor
Author
|
I also checked other translations and there was a lot of empty files that doesn't have any translations. I removed them. Also fixed minor issued that found. |
Member
|
Transifex will overwrite these changes, changes to translations must be done in Transifex. |
VishnuSanal
added
the
PR-Awaiting-Initial-Review
VishnuSanal
added
PR-Requested-Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For translations the Android now uses
values-lang-rREGIONscheme. In the sources there are two duplicated foldersvalues-euandvalues-eu-rES. I compared them and copied missing strings from the old to new and removed the duplicate.Same for other few locales