Skip to content

Empty password on SMB Dialog#4356

Open
abdulroufsidhu wants to merge 3 commits intoTeamAmaze:release/4.0from
abdulroufsidhu:release/4.0
Open

Empty password on SMB Dialog#4356
abdulroufsidhu wants to merge 3 commits intoTeamAmaze:release/4.0from
abdulroufsidhu:release/4.0

Conversation

@abdulroufsidhu
Copy link
Copy Markdown

@abdulroufsidhu abdulroufsidhu commented Feb 10, 2025

Description

Issue tracker

Fixes #4354

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@VishnuSanal VishnuSanal changed the title #4354 fixed Empty password on SMB Dialog Feb 10, 2025
@VishnuSanal VishnuSanal added the PR-Awaiting-Initial-Review this PR is awaiting for an initial review label Feb 10, 2025
@EmmanuelMess EmmanuelMess self-requested a review February 10, 2025 15:28
@EmmanuelMess
Copy link
Copy Markdown
Member

EmmanuelMess commented Feb 10, 2025

Code looks okay. Will wait for CI to test.

@VishnuSanal
Copy link
Copy Markdown
Member

@abdulroufsidhu please run spotless (./gradlew spotlessApply`)

@VishnuSanal VishnuSanal added the Needs-OPResponse Needs original poster to respond label Mar 22, 2026
@VishnuSanal
Copy link
Copy Markdown
Member

any updates here @abdulroufsidhu, thanks!

@abdulroufsidhu
Copy link
Copy Markdown
Author

any updates here @abdulroufsidhu, thanks!

appologies for the delay It's done. Thanks for the patience and cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs-OPResponse Needs original poster to respond PR-Awaiting-Initial-Review this PR is awaiting for an initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty password if possible

3 participants