Skip to content

feat deposit 생성 엔티티 설계#12

Open
xjvmdutl wants to merge 1 commit intodevfrom
feature-01/deposit/entity
Open

feat deposit 생성 엔티티 설계#12
xjvmdutl wants to merge 1 commit intodevfrom
feature-01/deposit/entity

Conversation

@xjvmdutl
Copy link
Contributor

  • Deposit 엔티티를 설계한다.
  • 책임 주도 설계를 기반으로 엔티티를 먼저 설계

- Deposit 엔티티를 설계한다.
- 책임주도설계를 기반으로 Method 작성한다.
@xjvmdutl xjvmdutl requested a review from a team November 29, 2025 11:20
@xjvmdutl xjvmdutl self-assigned this Nov 29, 2025
@xjvmdutl xjvmdutl requested review from ekfrehd, iOdiO89, jisubaek, mandykr and pparkjs and removed request for a team November 29, 2025 11:20
@xjvmdutl xjvmdutl added the enhancement New feature or request label Nov 29, 2025
@xjvmdutl xjvmdutl requested a review from Hajin-Bang November 29, 2025 11:20
Copy link

@pparkjs pparkjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요 ㅎㅎ
코맨트 달아놓은 부분 답장해주시면 감사하겠습니다!


public String getRefundFeeMessage() {
if (depositDate != null && depositDate.plusMonths(1).isAfter(LocalDateTime.now())) {
return "입금일 기준 30일이 초과되어 보증금 3.5%를 돌려 받을수 없습니다.";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 정책은 그냥 임의로 적어놓은 거라고 생각하면 되죠!?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pparkjs 님 해당 정책은 아래 이슈 기반해서 작성했다고 생각해주시면 될 거 같아요!
#1

정책 변경 > 이슈 변경 -> 코드 수정 Step으로 가면 될 것 같네요

Comment on lines +22 to +23
private long amount;
private long totalAmount;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 보증금 납부 회원들이 가지고있는 totalAmount에 의미를 이해하지 못했습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pparkjs
실제 보증금이 요청된 금액과 현재까지 납부한 보증 금액을 분리했다고 생각하시면 될 거 같아요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants