Merged
Conversation
added 2 commits
July 18, 2025 16:18
pparkjs
approved these changes
Jul 20, 2025
Comment on lines
+53
to
+55
| if (isSamePassword(member.getPassword().getValue(), request.password())) { //여기에 패스워드 검증 로직이 들어가는게 맞는지..? | ||
| member.delete(); | ||
| } |
There was a problem hiding this comment.
제가 생각했을때는 member.delete(request.password()) 로 받아서 해당 패스워드로직 검증을 도메인 안에서 따로 하는게 좋을 거 같아요! ---> 정정 아 passwordEncoder 때문에 도메인이 아니라 서비스 계층에서 검증하고 delete 하는게 맞겠네요 그대로가 좋은 거 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 PR 타입 선택
아래 타입 중 해당하는 하나를 선택해 주세요. 반드시 하나만 선택해 주세요.
feat: 새로운 기능 추가📝 변경 사항 요약
🛠 관련 이슈
Resolves: #11
추가 설명 (선택 사항)