Skip to content

Conversation

@LiliWuu
Copy link

@LiliWuu LiliWuu commented Oct 27, 2024

Please ensure your pull request adheres to the following requirements

Branch Name Pull Request

  • Completed the Pokemon assignment

Notes

  • Something new I learned was the abstract class

@NoahSimon8
Copy link

Great stuff Lilian! Great explanations in your README, I love to see it. You seem totally ready for robot training, so I hope your excited.

Two small things though

  • Constructors should go before all other methods, but after instance variables, in your class. This is just a small organizational thing though, changes nothing about actual performance
  • You're totally right about your example of subtype polymorphism, but I'd also like to point out it's use in the attack method. Because the take damage method is a part of the abstract class, we're able to send both types of pokemon into the attack method as parameters and call this method using their reference.
    image

Again, awesome job, and thanks for getting this in before Tuesday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants