Skip to content

Conversation

@Voyager162
Copy link

@Voyager162 Voyager162 commented Oct 25, 2024

Sorry Noah, I totally forgot the check for understanding ¯\_(ツ)_/¯. I also followed your instructions to put the constructers at the top of each subclass, and made all my instance variables in the pokemon class private and therefore I had to make a whole host of getters and setters for each variable. Thank you so much for the feedback.

@NoahSimon8
Copy link

Hey Weston,

Great job dude! I'm really impressed. You got the random import down, I love the static "fight" method, you have type casting--great stuff. Some of it wasn't covered in class, so whatever research you did is great. Even if AI suggested that that's how you do it, so long as you understand it then that's totally fine.

Few small things to note though

  • Where's your Check for Understanding (step 8 in instructions)?
  • In your child pokemon classes, your constructors should go before your methods. This is just a small organizational thing though
  • Your health, strength, and shield instance variables inside pokemon should be private--or at minimum, not default. Everything should be private or public (but again, this time it should be private). This will create reference errors in your child class, but you could fix that with more getters

Whether or not you actually fix those last two things is completely up to you, but please do lmk where I can find the check for understanding. I could just be blind, but in the alternative of you having not done it yet, just do it and send it over when you can. Great work!

…p of the pokemon child classes, made all the instance variables in the parent pokemon class private
@NoahSimon8
Copy link

Perfect, love to see it.

You're explanations are fantastic, I'm exctied to see you try out robot training next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants