Skip to content

chore: remove dev branch direct-push protection from hooks and update…#137

Merged
SeanSan06 merged 23 commits intodevfrom
seansan06/chore/remove-dev-push-protection
Mar 27, 2026
Merged

chore: remove dev branch direct-push protection from hooks and update…#137
SeanSan06 merged 23 commits intodevfrom
seansan06/chore/remove-dev-push-protection

Conversation

@SeanSan06
Copy link
Copy Markdown
Member

@SeanSan06 SeanSan06 commented Mar 13, 2026

Description(WIP, fixing merge conflicts)

This message last updated: 3/13/2026 10:48 pm

Removes the direct-push block on the dev branch from all git hooks and updates every doc, script, and onboarding file that referenced dev as a protected branch.

Previously, dev was blocked alongside main and master in the pre-push hook, preventing developers from pushing directly to it. dev is an integration branch — it should accept direct pushes and be merged into via PRs from feature branches. Only main and master branches need push protection.

  • Related Issue: (N/A)
  • Plaky feature name: (N/A)
  • Component affected: Git hooks, all team onboarding/docs, setup scripts
  • Purpose: Refactor / developer workflow improvement

Changes

  • Removed PROTECTION RULE 2 (exact dev block) from .git-hooks/pre-push and .githooks-template/pre-push
  • Updated post-checkout and post-merge hook messages: removed dev from the listed protected branches
  • Updated docs/CONTRIBUTING.md, START_HERE.md, COMPLETE_SETUP.md, README.md, FIND_YOUR_TASKS.md, docs/DOCUMENTATION_INDEX.md
  • Updated all 6 team onboarding docs under docs/onboarding/
  • Updated all 8 team_dev_environments/ READMEs
  • Updated all team_submodule_commands/ docs and setup-hooks.sh scripts
  • Updated scripts: auto-install-hooks.sh, install-all-git-hooks.sh, install-hooks-service.sh, sync-hooks-to-submodules.sh, sync-hooks-to-submodules-now.sh, setup-hooks.sh

Protected branches are now: main and master


Related


Testing

  • (N/A)

Important Notes (Optional)

  • Companion commits are needed in each of the 9 submodule repos (same branch name, same hook changes) — those PRs will follow
  • deepiri-landing, deepiri-emotion-desktop, deepiri-notideep are not in this workspace and will need separate PRs

Workflow Checklist (Required)

  • Branch is up to date with dev
  • PR is from your branch → dev (no longer directly into main)
  • PR title follows convention (chore:)
  • Plaky feature/bug name included above (N/A)
  • Tagged @Team-Deepiri/support-team
  • Plaky task moved to "Needs QA" (N/A)

Review Requests

@Team-Deepiri/support-team

… docs

    - Removed PROTECTION RULE 2 (exact 'dev' block) from .git-hooks/pre-push
    - Updated post-checkout/post-merge: removed 'dev' from protected-branch list in messages
    - Updated .githooks-template/ to match
    - Updated docs: CONTRIBUTING.md, START_HERE.md, COMPLETE_SETUP.md, README.md,
      FIND_YOUR_TASKS.md, docs/DOCUMENTATION_INDEX.md
    - Updated all 6 team onboarding docs under docs/onboarding/
    - Updated all 8 team_dev_environments READMEs
    - Updated all team_submodule_commands docs and setup-hooks.sh scripts
    - Updated scripts: auto-install-hooks.sh, install-all-git-hooks.sh,
      install-hooks-service.sh, sync-hooks-to-submodules.sh,
      sync-hooks-to-submodules-now.sh, setup-hooks.sh

    Protected branches are now: main, master, and branches containing 'team-dev'
    dev is now an open integration branch/push freely, use PRs to merge
Copy link
Copy Markdown
Contributor

@ChrisWoo0443 ChrisWoo0443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix merge conflicts
Other than that LGTM

jrb00013 and others added 12 commits March 21, 2026 13:48
refactor: extract ollama pre-pull logic into separate script under op…
- get_dirty_submodules: Refactored to use ThreadPoolExecutor for parallel processing - _check_submodule_dirty: Added helper function for submodule checks - _get_http_client: Added cached AsyncClient for HTTP requests
- lru_cache: Added to `get_merge_base` function for memoization. - _http_client: Introduced a global async httpx client with connection limits and caching logic in `_get_http_client`. - send_to_ollama, get_ollama_models: Updated to use the cached HTTP client instead of creating a new one per request. - _build_file_context: Added function to provide context for file merging based on file type and format. - resolve_file_with_context: Refactored to parallelize git calls using asyncio.to_thread and gather results.
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@8techy
Copy link
Copy Markdown
Member

8techy commented Mar 22, 2026

@SeanSan06 Could you fix these merge conflicts?

jrb00013 and others added 8 commits March 22, 2026 21:10
- Added ".opencode" entry to .gitignore to ignore generated files from the opencode tool
['- Introduced a new parameter `max_chars` in `_truncate_diff_for_commit_analysis` function for dynamic character limit adjustment.', '- Added conditions to use simple path when file count is <= AI_COMMIT_SIMPLE_MAX_FILES and no merge conflict markers are present.', '- Updated environment variable handling for performance tuning options.']
- Add function _normalise_commit_body to handle different types of input for the commit body.
- Add function _commit_body_lines which uses _normalise_commit_body and splits the body into lines.
- Update _normalise_commits_from_parsed and generate_pr_description functions to use _commit_body_lines.
- Updated the DESCRIPTION section instructions for clarity.
- Added detailed TESTING main and extra sections.
- Ensured clear guidance on how to verify changes locally.
- Added --full-auto and --full options for automated workflow.
- Updated error handling for failed checkouts.
- Improved branch selection feedback.
- Adjust OLLAMA_COMMIT_NUM_PREDICT default to 576 tokens
- Retain other performance-related environment variables unchanged
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@jrb00013
Copy link
Copy Markdown
Member

@SeanSan06 use the ai-conflict.py conflict resolution tool in the platform/scripts/git

@SeanSan06
Copy link
Copy Markdown
Member Author

@SeanSan06 use the ai-conflict.py conflict resolution tool in the platform/scripts/git

Sounds good I will handle this today

@SeanSan06
Copy link
Copy Markdown
Member Author

@jrb00013 Merge conflicts have been handled

@SeanSan06 SeanSan06 merged commit dde2f1d into dev Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants