feat(v2): wire marketplace discover → inspect → install loop#463
Merged
Conversation
The marketplace had three disconnected pieces: a (legacy-MUI) browse page, a v2-native detail page (#439) nothing linked to, and a detail "Install" button that bounced to /v2/agents/browse?installable=<id> — a param AgentsHub never read, so nothing installed. This connects them: - Browse cards (featured + All Apps) link to the v2 detail page in the v2 shell (gated on useV2Embedded; the detail route has no v1 equivalent). - AgentsHub consumes ?installable=<id> and auto-opens its existing install dialog for the matching catalog agent (matches installableId/name/id; no-ops gracefully if the catalog doesn't carry it — no regression). Activates already-shipped backend (#215/#230) + detail page (#439) into a working funnel. Publish/fork UI intentionally deferred. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The marketplace had three good pieces that weren't connected into a loop. This wires them — no new features, purely activating already-shipped work:
V2MarketplaceDetailPage, feat(v2-marketplace): manifest detail page at /v2/marketplace/:installableId #439), which was previously orphaned (nothing linked to it). Gated onuseV2Embedded— the detail route is v2-only, so the legacy/appsmount is unchanged./v2/agents/browse?installable=<id>, but AgentsHub only readpodId/agent/instanceId/view/tab— the param was dropped. AgentsHub now consumes?installable=<id>and auto-opens its existing install dialog for the matching catalog agent (matchesinstallableId/name/id; no-ops gracefully if the catalog doesn't carry it, so a miss just leaves the user on the browse list — no regression).Result: discover → inspect → install → talk now flows end-to-end (talk-to was landed in #462).
Backend (#215/#230) + detail page (#439) were already shipped; this is ~48 lines of wiring. Publish/fork/My-Manifests UI intentionally deferred (creator-side, post-GTM).
Test plan
AppsMarketplacePage.test.tsx, now wrapped inMemoryRouterfor the newuseNavigate)/appsmount unchanged (cards not clickable-to-detail there)