-
Notifications
You must be signed in to change notification settings - Fork 4
CLAP-181 댓글 수정 및 삭제 api 구현 #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
soft delete 할때 로직으로 구현하는대신 jpa에서 간단한 애노테이션을 제공하는데 한 번 확인해주셔도 좋을 것 같습니다. |
Collaborator
|
추가로 커밋 메세지의 경우 중복되거나 비슷한 내용일 경우 squash를 통해 합쳐서 커밋 해주시면 좋을 것 같습니다. |
hyoseong-Choi
approved these changes
Jan 31, 2025
Collaborator
Author
넵 이거 지금 rebate 과정에서 브랜치가 너무 난잡해져서 브랜치 새로파서 리팩토링 진행하겠습니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
댓글도 soft Delete가 필요하다고 판단하여 댓글 entity에 isDeleted 컬럼을 추가하였습니다.
첨부파일 댓글의 경우에는 별도의 수정 API가 필요없다고 tony와 얘기되어 댓글 수정은 일반 댓글만 가능하도록 구현해놓았습니다!
삭제 api를 하나로 구성하였습니다.
댓글 첨부파일일 경우
댓글 table에 있는 해당 컬럼의 isDeleted 를 true로 변경
attachment table에 있는 해당 컬럼의 isDeleted를 true로 변경
일반 댓글일 경우
댓글 table에 있는 해당 컬럼의 isDeleted 를 true로 변경
+++ @joowojr @parkjaehak CT-181 commit들만 review해주시면 될 것 같습니다!
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #{이슈 번호}