Skip to content

CLAP-180 REST API 설계 원칙에 맞게 url path 수정 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joowojr merged 1 commit into from
Jan 30, 2025
Merged

CLAP-180 REST API 설계 원칙에 맞게 url path 수정 #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/clap/server/adapter/inbound/web/task/ChangeTaskController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class ChangeTaskController {

@Operation(summary = "작업 상태 변경")
@Secured("ROLE_MANAGER")
@PatchMapping("/state/{taskId}")
@PatchMapping("/{taskId}/status")
public ResponseEntity<UpdateTaskResponse> updateTaskState(
@PathVariable @NotNull Long taskId,
@AuthenticationPrincipal SecurityUserDetails userInfo,
Expand All @@ -43,7 +43,7 @@ public ResponseEntity<UpdateTaskResponse> updateTaskState(

@Operation(summary = "작업 처리자 변경")
@Secured({"ROLE_MANAGER"})
@PatchMapping("/processor/{taskId}")
@PatchMapping("/{taskId}/processor")
public ResponseEntity<UpdateTaskResponse> updateTaskProcessor(
@PathVariable Long taskId,
@AuthenticationPrincipal SecurityUserDetails userInfo,
Expand All @@ -53,7 +53,7 @@ public ResponseEntity<UpdateTaskResponse> updateTaskProcessor(

@Operation(summary = "작업 구분 변경")
@Secured({"ROLE_MANAGER"})
@PatchMapping("/label/{taskId}")
@PatchMapping("/{taskId}/label")
public ResponseEntity<UpdateTaskResponse> updateTaskLabel(
@PathVariable Long taskId,
@AuthenticationPrincipal SecurityUserDetails userInfo,
Expand All @@ -63,7 +63,7 @@ public ResponseEntity<UpdateTaskResponse> updateTaskLabel(

@Operation(summary = "작업 승인")
@Secured({"ROLE_MANAGER"})
@PostMapping("/approval/{taskId}")
@PostMapping("/{taskId}/approval")
public ResponseEntity<ApprovalTaskResponse> approvalTask(
@RequestBody @Valid ApprovalTaskRequest approvalTaskRequest,
@PathVariable Long taskId,
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/clap/server/adapter/inbound/web/task/FindTaskController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public ResponseEntity<Page<FilterRequestedTasksResponse>> findTasksRequestedByUs
}
@Operation(summary = "요청한 작업 상세 조회")
@Secured({"ROLE_USER", "ROLE_MANAGER"})
@GetMapping("/requests/details/{taskId}")
@GetMapping("/{taskId}/requests/details")
public ResponseEntity<FindTaskDetailsResponse> findRequestedTaskDetails(
@PathVariable Long taskId,
@AuthenticationPrincipal SecurityUserDetails userInfo){
Expand Down Expand Up @@ -72,7 +72,7 @@ public ResponseEntity<Page<FilterAllTasksResponse>> findAllTasks(

@Operation(summary = "전체요청, 내 작업에 대한 상세 조회")
@Secured("ROLE_MANAGER")
@GetMapping("/details/{taskId}")
@GetMapping("/{taskId}/details")
public ResponseEntity<FindTaskDetailsForManagerResponse> findRequestedTaskDetailsForManager(
@PathVariable Long taskId,
@AuthenticationPrincipal SecurityUserDetails userInfo) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/clap/server/adapter/inbound/web/task/FindTaskHistoryController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class FindTaskHistoryController {

@Operation(summary = "작업 히스토리 조회")
@Secured({"ROLE_MANAGER","ROLE_USER"})
@GetMapping("/histories/{taskId}")
@GetMapping("/{taskId}/histories")
public ResponseEntity<FindTaskHistoryResponse> findTaskHistories(
@PathVariable Long taskId,
@AuthenticationPrincipal SecurityUserDetails userInfo) {
Expand Down
Loading