구분 추가 API 구현 #163
Merged
구분 추가 API 구현 #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkjaehak
reviewed
Jan 29, 2025
src/main/java/clap/server/adapter/inbound/web/admin/UpdateLabelController.java
Show resolved
Hide resolved
parkjaehak
requested changes
Jan 29, 2025
Comment on lines
+19
to
+24
| @Override | ||
| public void addLabel(Long adminId, AddLabelRequest request) { | ||
| Member admin = memberService.findActiveMember(adminId); | ||
| Label label = Label.addLabel(admin, request); | ||
| commandLabelPort.save(label); | ||
| } |
Collaborator
There was a problem hiding this comment.
트랜잭션 작업의 단위로 묶는 것이 필요해보입니다!
Collaborator
Author
There was a problem hiding this comment.
아 그거 빼먹었네요ㅠ 감사합니다
parkjaehak
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #{이슈 번호}