-
Notifications
You must be signed in to change notification settings - Fork 4
CLAP-155 작업 보드 순서 변경 API 구현 및 알림 client 설정 환경변수화 #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starboxxxx
reviewed
Jan 29, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joowojr build 에러 또 나는거 같습니다! test 폴더쪽에 있는 application.yml에도 환경 설정 추가해주셔야할거 같아요!
Contributor
Author
넵 이거 ci test 단계에서 시크릿으로 주입해야할거 같아 효성님께 전달드리겠습니다! |
<footer> - 관련: #133
parkjaehak
approved these changes
Jan 29, 2025
<footer> - 관련: #123
<footer> - 관련: #123
<footer> - 관련: #123
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
<footer> - 관련: #133
# Conflicts: # src/main/java/clap/server/application/Task/UpdateTaskService.java
<footer> - 관련: #133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
✨ 작업 보드 순서 변경 API 구현
0️⃣ processorOrder 계산 로직
1️⃣ updateTaskOrder() - 작업의 순서 변경
요청 데이터 검증
위치에 따른 순서 변경
2️⃣ updateTaskOrderAndStatus() - 작업의 상태 및 순서 변경
요청 데이터 검증
위치에 따른 상태 변경 및 순서 변경
♻️ 리팩토링
webhook, email client 관련 설정을 환경변수로 관리
memberService에 승인권한이 있는 담당자를 조회하는 메서드 추가하여 리팩토링
작업 수정 시에 요청을 한 담당자가 해당 작업의 담당자인지 검증하는 로직 도메인 레벨로 이동
작업이 요청 상태인지 검증하는 로직 도메인 레벨로 이동
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #133