Skip to content

CLAP-128 2차 카테고리 추가 API #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hyoseong-Choi merged 19 commits into from
Jan 25, 2025
Merged

CLAP-128 2차 카테고리 추가 API #100

hyoseong-Choi merged 19 commits into from
Jan 25, 2025

Conversation

@hyoseong-Choi
Copy link
Collaborator

@hyoseong-Choi hyoseong-Choi commented Jan 25, 2025

📄 요약(Summary)

2차 카테고리 추가 API

✍🏼 상세(More)

PR Desciption

변경 사항 설명

  • 컨트롤러에서 역할 확인 및 입력 검증합니다
  • 서비스에서 유효한 관리자인지, 1차 카테고리 id가 유효한지 확인하고 맞으면 카테고리 생성해 저장합니다

Requirements for Reviewer

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요
ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

PR Log

PR 작업하면서 고민했던 내용, 해결한 내용, 고민 중인 내용 등

새롭게 배운 것

고민 중인 사항

첨부 자료

✅ 체크리스트(Checklist)

  • PR 양식에 맞게 작성했습니다
  • 모든 테스트가 통과했습니다
  • 프로그램이 정상적으로 작동합니다
  • 적절한 PR 라벨을 설정했습니다
  • 불필요한 코드를 제거했습니다

🚪 이슈 번호(Issue numbers)

Closes #95

hyoseong-Choi and others added 18 commits January 23, 2025 13:38
@hyoseong-Choi
CLAP-104 CI/CD : dev 환경 cd 스크립트 checkout 버전수정
19bff02 
<footer>
- 관련: #55
@hyoseong-Choi
Merge branch 'develop' of https://github.com/TaskFlow-CLAP/TaskFlow-S…
a3fe141 
…erver into develop
@hyoseong-Choi
Merge branch 'develop' of https://github.com/TaskFlow-CLAP/TaskFlow-S…
87ee143 
…erver into develop
@hyoseong-Choi
Merge branch 'develop' of https://github.com/TaskFlow-CLAP/TaskFlow-S…
0a5bdf1 
…erver into develop
@hyoseong-Choi
CLAP-110 Feature : 담당자별 작업 처리량 조회 API 구현
c97d37c 
<footer>
- 관련: #73
@hyoseong-Choi
CLAP-111 Refactor : 통계 조회 API 리팩토링 및 기능 수정
73bd762 
<footer>
- 관련: #74
@nano-mm
내 작업한 내용에 대한 설명
60ebc4a
@nano-mm
내 작업한 내용에 대한 설명
a88a6bf
@nano-mm
Resolve merge conflict in application.yml
1bf4ffb
@nano-mm
담당자 조회 API 구현
283e5a5
@hyoseong-Choi
Merge branch 'develop' of https://github.com/TaskFlow-CLAP/TaskFlow-S…
0ec9b91 
…erver into develop
@hyoseong-Choi
CLAP-111 Refactor : 통계 조회 API 주소 통합, 리팩토링, 예외처리
2a9eed4 
<footer>
- 관련: #74
@hyoseong-Choi
CLAP-111 Test : 테스트코드 및 설정 수정
ea99e9f 
<footer>
- 관련: #74
@hyoseong-Choi
Merge branch 'develop' of https://github.com/TaskFlow-CLAP/TaskFlow-S…
0bf52d6 
…erver into develop
@hyoseong-Choi
Merge branch 'develop' of https://github.com/TaskFlow-CLAP/TaskFlow-S…
0372f2c 
…erver into develop
@hyoseong-Choi
Bug : 프로퍼티파일 수정
24c582d
@hyoseong-Choi
Merge branch 'develop' of https://github.com/TaskFlow-CLAP/TaskFlow-S…
269fa7d 
…erver into develop
@hyoseong-Choi
CLAP-128 Feature : 2차 카테고리 추가 API
56c005c 
<footer>
- 관련: #95
@hyoseong-Choi hyoseong-Choi added ✨ feature 구현·개선 사항에 관련된 내용입니다 HIGH 우선순위 상 labels Jan 25, 2025
@hyoseong-Choi hyoseong-Choi self-assigned this Jan 25, 2025
@hyoseong-Choi hyoseong-Choi requested review from Sihun23 and joowojr and removed request for Sihun23 and joowojr January 25, 2025 07:05
joowojr
joowojr requested changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@joowojr joowojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 리뷰 확인 부탁드려요!

@hyoseong-Choi hyoseong-Choi merged commit 67672ec into develop Jan 25, 2025
1 check passed
@hyoseong-Choi hyoseong-Choi deleted the CLAP-128 branch January 25, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joowojr joowojr joowojr requested changes

@Sihun23 Sihun23 Awaiting requested review from Sihun23

Assignees

@hyoseong-Choi hyoseong-Choi

Labels

✨ feature 구현·개선 사항에 관련된 내용입니다 HIGH 우선순위 상

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLAP-128 2차 카테고리 추가 API

4 participants

@hyoseong-Choi @joowojr @nano-mm