Conversation
Member
Author
Member
Author
|
When we added If we try to apply this method of I only got that working 10 minutes ago, so I'm still reconsidering how best to approach it in scrypt. (But the PRs you already merged are still good.) |
libcpusupport_crypto_aes.la needs to resolve symbols such as
cpusupport_x86_aesni_detect_1. In scrypt, that was previously provided
by cpusupport_x86_aesni.o, which was listed explicitly on the
command-line (via Makefile.am's ${crypto_scrypt_files}).
However, in the tarsnap repository, cpusupport_x86_aesni.o was linked
into libtarsnap.a. When we tried to add libcperciva_crypto_aes.a, that
created a circular dependency:
- libtarsnap.a needed crypto_aes symbols (which were in
libcperciva_crypto_aes)
- libcperciva_crypto_aes needed cpusupport_x86_aesni_detect_1 (which
were in libtarsnap.a)
To avoid the circular dependency, we're moving the cpusupport detection
functionality into its own library. We're also clarifying the order of
libraries in the scrypt_LDADD list.
gperciva
force-pushed
the
build-style-sort
branch
from
c4fe803 to
86bb518
Compare
Also, remove memlimit.h from libscrypt_memlimit.la; it's not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.