fix: add 'instant' to ScrollBehavior type#1138
Closed
isaackaara wants to merge 1 commit intoTanStack:mainfrom
Closed
fix: add 'instant' to ScrollBehavior type#1138isaackaara wants to merge 1 commit intoTanStack:mainfrom
isaackaara wants to merge 1 commit intoTanStack:mainfrom
Conversation
The native browser scrollTo API supports three behavior values: 'auto', 'smooth', and 'instant'. The ScrollBehavior type was missing 'instant', causing a TypeScript error when passing behavior: 'instant' to scrollToIndex even though it works fine at runtime. Fixes TanStack#1074
|
Collaborator
|
Closing as duplicate of #1122 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ScrollBehaviortype was defined as'auto' | 'smooth', missing'instant'.The native browser
scrollToAPI supports three values:auto,smooth, andinstant. Passingbehavior: 'instant'toscrollToIndexworks at runtime but TypeScript rejects it.One-line change: adds
'instant'to the union type invirtual-core/src/index.ts.Fixes #1074