fix(virtual-core): early return in _measureElement for disconnected nodes#1135
Merged
piecyk merged 3 commits intoTanStack:mainfrom Mar 5, 2026
Merged
fix(virtual-core): early return in _measureElement for disconnected nodes#1135piecyk merged 3 commits intoTanStack:mainfrom
piecyk merged 3 commits intoTanStack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d75f9c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit d75f9c9
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1133
🎯 Changes
Fix stale ResizeObserver callbacks corrupting elementsCache after item deletion.
When items are removed from the list, ResizeObserver can still fire for DOM nodes that are no longer connected to the document. Previously, the node.isConnected check was at the bottom of _measureElement, only guarding the resizeItem call. This allowed the cache swap logic above it to run, unobserving the correct element for a key and storing a dead node in its place.
Fix: Move the !node.isConnected check to the top of _measureElement so we bail out before touching any caches. The disconnected node is also unobserved to prevent future stale callbacks.
Additionally, restructured the Playwright e2e test app into a multi-page setup and added an e2e test that reproduces the exact expand, collapse, delete, expand scenario.
✅ Checklist
pnpm run test:pr.🚀 Release Impact