Skip to content

fix(table-core): use autoRemove instead of resolveFilterValue on comparison filter fns #6213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkdfx wants to merge 1 commit into
base: alpha
Choose a base branch
from
+4 −4
Open

fix(table-core): use autoRemove instead of resolveFilterValue on comparison filter fns #6213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/table-core/src/fns/filterFns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export const filterFn_greaterThan: FilterFn<any, any> = <
return stringValue > stringFilterValue
}

filterFn_greaterThan.resolveFilterValue = (val: any) => testFalsy(val)
filterFn_greaterThan.autoRemove = (val: any) => testFalsy(val)

/**
* Filter function for checking if a number is greater than or equal to a given number.
Expand All @@ -160,7 +160,7 @@ export const filterFn_greaterThanOrEqualTo: FilterFn<any, any> = <
)
}

filterFn_greaterThanOrEqualTo.resolveFilterValue = (val: any) => testFalsy(val)
filterFn_greaterThanOrEqualTo.autoRemove = (val: any) => testFalsy(val)

/**
* Filter function for checking if a number is less than a given number.
Expand All @@ -176,7 +176,7 @@ export const filterFn_lessThan: FilterFn<any, any> = <
return !filterFn_greaterThanOrEqualTo(row as any, columnId, filterValue)
}

filterFn_lessThan.resolveFilterValue = (val: any) => testFalsy(val)
filterFn_lessThan.autoRemove = (val: any) => testFalsy(val)

/**
* Filter function for checking if a number is less than or equal to a given number.
Expand All @@ -192,7 +192,7 @@ export const filterFn_lessThanOrEqualTo: FilterFn<any, any> = <
return !filterFn_greaterThan(row as any, columnId, filterValue)
}

filterFn_lessThanOrEqualTo.resolveFilterValue = (val: any) => testFalsy(val)
filterFn_lessThanOrEqualTo.autoRemove = (val: any) => testFalsy(val)

// Range filters

Expand Down