Skip to content

Conversation

@KevinVandy
Copy link
Member

It has been suggested that we don't import from preact/compat. Here is our own uSES implementation with credit given

@nx-cloud
Copy link

nx-cloud bot commented Dec 3, 2025

View your CI Pipeline Execution ↗ for commit 207e55d

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 43s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-03 01:36:26 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 3, 2025

@tanstack/angular-store

npm i https://pkg.pr.new/@tanstack/angular-store@260

@tanstack/preact-store

npm i https://pkg.pr.new/@tanstack/preact-store@260

@tanstack/react-store

npm i https://pkg.pr.new/@tanstack/react-store@260

@tanstack/solid-store

npm i https://pkg.pr.new/@tanstack/solid-store@260

@tanstack/store

npm i https://pkg.pr.new/@tanstack/store@260

@tanstack/svelte-store

npm i https://pkg.pr.new/@tanstack/svelte-store@260

@tanstack/vue-store

npm i https://pkg.pr.new/@tanstack/vue-store@260

commit: 207e55d

Copy link

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Copying from Twitter in case it helps to have approval here too)

Something like this is definitely preferable & reduces the overall bundle, thanks for doing it! As Jovi mentioned, you could save a quite a few bytes by just setting up the subscription stuff manually and not trying to use this API specifically, but if you want general parity w/ the React impl, there's nothing wrong with this.

As mentioned in the other PR, I'll poke around with creating a separate entrypoint in Preact itself but not sure when I'll have time or if that'll go anywhere.

@KevinVandy KevinVandy merged commit 7e0dc5f into main Dec 3, 2025
4 checks passed
@KevinVandy KevinVandy deleted the fix-remove-preact-compat branch December 3, 2025 14:49
@theVedanta
Copy link
Contributor

this is pretty cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants