Skip to content

perf(start-server-core): skip update for server context #7599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sheraff merged 2 commits into from
Jun 11, 2026
+8 −1
Merged

perf(start-server-core): skip update for server context #7599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eb946a
perf(start-server-core): skip update for server context
Sheraff Jun 11, 2026
a3026ac
changeset
Sheraff Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-insects-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/start-server-core': patch
---

Skip a full router.update for faster createStartHandler
4 changes: 3 additions & 1 deletion packages/start-server-core/src/createStartHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,9 @@ export function createStartHandler<TRegister = Register>(
getStartContext({ throwIfNotFound: false })?.requestAssets,
})

routerInstance.update({ additionalContext: { serverContext } })
// `additionalContext` is request-scoped and only read from router.options
// during load; avoid a full router.update() and redundant location parse.
routerInstance.options.additionalContext = { serverContext }
await routerInstance.load()

if (routerInstance.state.redirect) {
Expand Down
Loading