fix(start): align Rsbuild SSR asset URLs for css?url imports#7590
fix(start): align Rsbuild SSR asset URLs for css?url imports#7590SyMind wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThis PR fixes a Rsbuild SSR asset URL duplication issue by aligning server public asset paths with client build outputs. It refactors the Rsbuild environment planning to use standardized ChangesRsbuild SSR Asset URL Alignment and E2E Validation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you very much for such a quick fix! |
Fix #7543
css?urlimports resolve to client-served asset URLs.rsc-rsbuilde2e route that imports a stylesheet with?urland verifies the actual element style is applied.rsc-rsbuildfixture homepage and node_modules client component page to match the main RSC fixture’s server/client visual style.Summary by CodeRabbit
Release Notes
Bug Fixes
?urlsyntax by aligning asset path configuration between client and server builds.Tests
?urlare correctly applied during server-side rendering.