Skip to content

refactor: solid link perf #6836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sheraff merged 6 commits into from
Mar 7, 2026
Merged

refactor: solid link perf #6836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4868c97
refactor: solid link perf
Sheraff Mar 6, 2026
760cc0e
perf: streamline solid match lookups
Sheraff Mar 6, 2026
766b5b1
try double memo w/ fast path pick
Sheraff Mar 6, 2026
966cdd1
more idiomatic solid code
Sheraff Mar 7, 2026
137062c
Merge branch 'refactor-signals' into refactor-signals-solid-link-perf
Sheraff Mar 7, 2026
12ba138
cleanup indirections in Match
Sheraff Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/react-router/src/link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,19 +389,16 @@ export function useLinkProps<
// computation when the leaf route/params context changes.
// eslint-disable-next-line react-hooks/rules-of-hooks
const currentLeafMatchId = useStore(router.stores.lastMatchId, (id) => id)
const from = options.from

// eslint-disable-next-line react-hooks/rules-of-hooks
const _options = React.useMemo(
() => {
return { ...options, from }
},
() => options,
// eslint-disable-next-line react-hooks/exhaustive-deps
[
router,
currentLeafMatchId,
currentLocation.hash,
from,
options.from,
options._fromLocation,
options.hash,
options.to,
Expand Down
Loading
Loading