Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experimental adapter for Angular. The package has a experimental sufix since the public API might change.
It is similar to Solid, except for the rendering: Angular has no concept of Error boundaries, Suspense, and the API's for dynamic components aren't as great as the ones in JSX.
The bubbling of errors states across matches is emulated by looking if there is no error component between the current match and the first child match that with an error. A similar behaviour for loading bubbling (suspense) could be implemented, but since that behaviour in other frameworks "suspends" the child matches of the one that catched the loading state before un-suspending it when ready, and since in Angular there is no APis that I could find to archive the desired behavior, that feature was left out.
While this took a lot of inspiration from an early adopter, this version intentionally avoids been more "Angular friendly", from not having first class support for Angular's DI system, to not providing any RxJS API. That decision alights the adapter better with how the other adapters work, but I'm open to suggestions if we could add/change an API to improve the DX in Angular.
Deploy of the kitchen-sink example: https://angular-router.benjavicente.workers.dev