Skip to content

test(query-core): replace deprecated 'toBeCalledWith' and 'toBeCalledTimes' with 'toHaveBeenCalledWith' and 'toHaveBeenCalledTimes' #10936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukvvon wants to merge 6 commits into
base: main
Choose a base branch
from
+12 −12
Open

test(query-core): replace deprecated 'toBeCalledWith' and 'toBeCalledTimes' with 'toHaveBeenCalledWith' and 'toHaveBeenCalledTimes' #10936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1fd6328
test(query-core): replace deprecated 'toBeCalledWith' and 'toBeCalled…
sukvvon Jun 14, 2026
656027f
Merge branch 'main' into test/query-core-replace-deprecated-vitest-al…
sukvvon Jun 14, 2026
c842986
Merge branch 'main' into test/query-core-replace-deprecated-vitest-al…
sukvvon Jun 14, 2026
412b162
Merge branch 'main' into test/query-core-replace-deprecated-vitest-al…
sukvvon Jun 14, 2026
923e29d
Merge branch 'main' into test/query-core-replace-deprecated-vitest-al…
sukvvon Jun 14, 2026
47b6fc8
Merge branch 'main' into test/query-core-replace-deprecated-vitest-al…
sukvvon Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/query-core/src/__tests__/infiniteQueryObserver.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe('InfiniteQueryObserver', () => {
expect(observerResult).toMatchObject({
data: { pages: ['1'], pageParams: [1] },
})
expect(queryFn).toBeCalledWith(expect.objectContaining({ meta }))
expect(queryFn).toHaveBeenCalledWith(expect.objectContaining({ meta }))
})

it('should make getNextPageParam and getPreviousPageParam receive current pageParams', async () => {
Expand Down Expand Up @@ -162,7 +162,7 @@ describe('InfiniteQueryObserver', () => {
await vi.advanceTimersByTimeAsync(10)

expect(observer.getCurrentResult().data?.pages).toEqual(['1', '2'])
expect(queryFn).toBeCalledTimes(2)
expect(queryFn).toHaveBeenCalledTimes(2)
expect(observer.getCurrentResult().hasNextPage).toBe(true)

next = undefined
Expand All @@ -171,7 +171,7 @@ describe('InfiniteQueryObserver', () => {
await vi.advanceTimersByTimeAsync(10)

expect(observer.getCurrentResult().data?.pages).toEqual(['1'])
expect(queryFn).toBeCalledTimes(3)
expect(queryFn).toHaveBeenCalledTimes(3)
expect(observer.getCurrentResult().hasNextPage).toBe(false)
})

Expand All @@ -194,7 +194,7 @@ describe('InfiniteQueryObserver', () => {
await vi.advanceTimersByTimeAsync(10)

expect(observer.getCurrentResult().data?.pages).toEqual(['1', '2'])
expect(queryFn).toBeCalledTimes(2)
expect(queryFn).toHaveBeenCalledTimes(2)
expect(observer.getCurrentResult().hasNextPage).toBe(true)

next = null
Expand All @@ -203,7 +203,7 @@ describe('InfiniteQueryObserver', () => {
await vi.advanceTimersByTimeAsync(10)

expect(observer.getCurrentResult().data?.pages).toEqual(['1'])
expect(queryFn).toBeCalledTimes(3)
expect(queryFn).toHaveBeenCalledTimes(3)
expect(observer.getCurrentResult().hasNextPage).toBe(false)
})

Expand Down
8 changes: 4 additions & 4 deletions packages/query-core/src/__tests__/mutationObserver.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ describe('mutationObserver', () => {

unsubscribe1()

expect(subscription1Handler).toBeCalledTimes(1)
expect(subscription2Handler).toBeCalledTimes(1)
expect(subscription1Handler).toHaveBeenCalledTimes(1)
expect(subscription2Handler).toHaveBeenCalledTimes(1)

await vi.advanceTimersByTimeAsync(20)
expect(subscription1Handler).toBeCalledTimes(1)
expect(subscription2Handler).toBeCalledTimes(2)
expect(subscription1Handler).toHaveBeenCalledTimes(1)
expect(subscription2Handler).toHaveBeenCalledTimes(2)

unsubscribe2()
})
Expand Down
4 changes: 2 additions & 2 deletions packages/query-core/src/__tests__/queriesObserver.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,9 @@ describe('queriesObserver', () => {
await vi.advanceTimersByTimeAsync(20)

// 1 call: pending
expect(subscription1Handler).toBeCalledTimes(1)
expect(subscription1Handler).toHaveBeenCalledTimes(1)
// 1 call: success
expect(subscription2Handler).toBeCalledTimes(1)
expect(subscription2Handler).toHaveBeenCalledTimes(1)

// Clean-up
unsubscribe2()
Expand Down
2 changes: 1 addition & 1 deletion packages/query-core/src/__tests__/query.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ describe('query', () => {

await queryClient.prefetchQuery({ queryKey: key, queryFn, meta })

expect(queryFn).toBeCalledWith(
expect(queryFn).toHaveBeenCalledWith(
expect.objectContaining({
meta,
}),
Expand Down
Loading