test(query-core/queryObserver): add test for 'getOptimisticResult' updating 'currentResult' with changed data by sukvvon · Pull Request #10102 · TanStack/query

sukvvon · 2026-02-07T06:46:04Z

🎯 Changes

Add a test to verify that getOptimisticResult updates currentResult when the query data has changed between renders (e.g., via setQueryData).

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

…dating 'currentResult' with changed data

changeset-bot · 2026-02-07T06:46:12Z

⚠️ No Changeset found

Latest commit: 717d5d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-07T06:46:20Z

📝 Walkthrough

Walkthrough

This PR adds a test case to validate that QueryObserver.getOptimisticResult correctly reflects updated cached data after queryClient.setQueryData is called, ensuring the observer properly tracks cache changes.

Changes

Cohort / File(s)	Summary
Test Addition `packages/query-core/src/__tests__/queryObserver.test.tsx`	Adds a test verifying that `getOptimisticResult` returns updated data after the cache is modified via `queryClient.setQueryData`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

fix(core): observing "promise" needs to implicitly observe "data" #9772: Also modifies QueryObserver's tracking behavior with respect to data observation and promise access.

Suggested labels

package: query-core

Poem

🐰 A curious test hops through the cache,
Checking if observers match the facts,
When data updates, optimistic and bright,
The results align, everything's right! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the primary change: adding a test for getOptimisticResult updating currentResult with changed data in queryObserver.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description follows the template structure with all required sections completed. The Changes section clearly describes the test being added, the Checklist shows both contributing guide and testing steps have been completed, and Release Impact correctly identifies this as a dev-only change.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-02-07T06:46:37Z

View your CI Pipeline Execution ↗ for commit 717d5d8

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 50s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-07 06:52:04 UTC

pkg-pr-new · 2026-02-07T06:48:53Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10102

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10102

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10102

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10102

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10102

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10102

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10102

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10102

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10102

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10102

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10102

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10102

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10102

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10102

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10102

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10102

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10102

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10102

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10102

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10102

commit: 717d5d8

test(query-core/queryObserver): add test for 'getOptimisticResult' up…

717d5d8

…dating 'currentResult' with changed data

github-actions bot added the package: query-core label Feb 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(query-core/queryObserver): add test for 'getOptimisticResult' updating 'currentResult' with changed data#10102

test(query-core/queryObserver): add test for 'getOptimisticResult' updating 'currentResult' with changed data#10102
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/query-core-queryObserver-getOptimisticResult-update-currentResult

sukvvon commented Feb 7, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 7, 2026

Uh oh!

coderabbitai bot commented Feb 7, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloud bot commented Feb 7, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Uh oh!

changeset-bot bot commented Feb 7, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloud bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Feb 7, 2026 •

edited

Loading

coderabbitai bot commented Feb 7, 2026 •

edited

Loading

nx-cloud bot commented Feb 7, 2026 •

edited

Loading