Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,84 @@ describe('QueryErrorResetBoundary', () => {

consoleMock.mockRestore()
})

it('should refetch after error when staleTime is Infinity and previous data exists (#9728)', async () => {
const key = queryKey()
const queryFn = vi.fn()
let count = 0

queryFn.mockImplementation(async () => {
await sleep(10)
count++
if (count === 2) {
throw new Error('Error ' + count)
}
return 'Success ' + count
})

function Page() {
const [_, forceUpdate] = React.useState(0)

React.useEffect(() => {
forceUpdate(1)
}, [])

const { data, refetch } = useQuery({
queryKey: key,
queryFn,
retry: false,
staleTime: Infinity,
throwOnError: true,
})

return (
<div>
<div>Data: {data}</div>
<button onClick={() => refetch()}>Refetch</button>
</div>
)
}

const rendered = renderWithClient(
queryClient,
<React.StrictMode>
<QueryErrorResetBoundary>
{({ reset }) => (
<ErrorBoundary
onReset={reset}
fallbackRender={({ resetErrorBoundary }) => (
<div>
<div>Status: error</div>
<button onClick={resetErrorBoundary}>Retry</button>
</div>
)}
>
<Page />
</ErrorBoundary>
)}
</QueryErrorResetBoundary>
</React.StrictMode>,
)

// 1. First mount -> fetching -> Success
await vi.advanceTimersByTimeAsync(11)
expect(rendered.getByText('Data: Success 1')).toBeInTheDocument()
expect(queryFn).toHaveBeenCalledTimes(1)

// 2. Click Refetch -> Triggers fetch -> Fails (Error 2) -> ErrorBoundary
fireEvent.click(rendered.getByText('Refetch'))
await vi.advanceTimersByTimeAsync(11)
expect(rendered.getByText('Status: error')).toBeInTheDocument()
expect(queryFn).toHaveBeenCalledTimes(2)

// 3. Click Retry -> Remounts
// Because staleTime is Infinity and we have Data from (1),
// AND we are in Error state.
fireEvent.click(rendered.getByText('Retry'))
await vi.advanceTimersByTimeAsync(11)
expect(rendered.getByText('Data: Success 3')).toBeInTheDocument()
expect(queryFn).toHaveBeenCalledTimes(3)
})
})

describe('useQueries', () => {
Expand Down
108 changes: 0 additions & 108 deletions packages/react-query/src/__tests__/issue-9728.test.tsx

This file was deleted.

Loading