fix(form-core): exclude undefined from FormState errors type#2066
Open
isaackaara wants to merge 1 commit intoTanStack:mainfrom
Open
fix(form-core): exclude undefined from FormState errors type#2066isaackaara wants to merge 1 commit intoTanStack:mainfrom
isaackaara wants to merge 1 commit intoTanStack:mainfrom
Conversation
The runtime code filters out undefined values from the errorMap when building the errors array (via .filter(val => val !== undefined)), but the type definition allowed undefined in the union. This forced consumers to add unnecessary runtime undefined checks when iterating over errors. Wrapping the error union with NonNullable aligns the type with the actual runtime behavior. Fixes TanStack#2022
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime code in
FormApi.tsexplicitly filters outundefinedvalues from the error map when building theerrorsarray:But the type definition allows
undefinedin the union, forcing consumers to add unnecessaryundefinedchecks:This wraps the error union types with
NonNullable<>in both theFormState.errorstype and thegetAllErrors()return type, aligning the types with the runtime behavior.Fixes #2022