Skip to content

Remove solid js from peer deps#371

Open
birkskyum wants to merge 5 commits intoTanStack:mainfrom
birkskyum:remove-solid-js-from-peer-deps
Open

Remove solid js from peer deps#371
birkskyum wants to merge 5 commits intoTanStack:mainfrom
birkskyum:remove-solid-js-from-peer-deps

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Mar 6, 2026

This PR removes solid-js v1 from peerDeps, because it gets in the way of e.g. router-devtools-core upgrading to solid v2. PR here:

With this pr the devtools become compatible with router devtools of both solid v1 and solid v2

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2026

🦋 Changeset detected

Latest commit: bcbf1e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@tanstack/devtools-utils Patch
@tanstack/solid-devtools Patch
@tanstack/devtools-ui Patch
@tanstack/devtools Patch
@tanstack/preact-devtools Patch
@tanstack/react-devtools Patch
@tanstack/vue-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Mar 6, 2026

View your CI Pipeline Execution ↗ for commit bcbf1e6

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 36s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 24s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-06 21:29:19 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 6, 2026

More templates

@tanstack/devtools

npm i https://pkg.pr.new/@tanstack/devtools@371

@tanstack/devtools-client

npm i https://pkg.pr.new/@tanstack/devtools-client@371

@tanstack/devtools-ui

npm i https://pkg.pr.new/@tanstack/devtools-ui@371

@tanstack/devtools-utils

npm i https://pkg.pr.new/@tanstack/devtools-utils@371

@tanstack/devtools-vite

npm i https://pkg.pr.new/@tanstack/devtools-vite@371

@tanstack/devtools-event-bus

npm i https://pkg.pr.new/@tanstack/devtools-event-bus@371

@tanstack/devtools-event-client

npm i https://pkg.pr.new/@tanstack/devtools-event-client@371

@tanstack/preact-devtools

npm i https://pkg.pr.new/@tanstack/preact-devtools@371

@tanstack/react-devtools

npm i https://pkg.pr.new/@tanstack/react-devtools@371

@tanstack/solid-devtools

npm i https://pkg.pr.new/@tanstack/solid-devtools@371

@tanstack/vue-devtools

npm i https://pkg.pr.new/@tanstack/vue-devtools@371

commit: 639e746

@birkskyum birkskyum marked this pull request as draft March 6, 2026 21:23
@birkskyum birkskyum marked this pull request as ready for review March 6, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant