⛓️💥 HTM-1875: update viewer API model to provide styles to viewer#1593
Merged
⛓️💥 HTM-1875: update viewer API model to provide styles to viewer#1593
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1593 +/- ##
======================================
+ Coverage 78% 78% +1%
Complexity 132 132
======================================
Files 155 155
Lines 7669 7674 +5
Branches 703 703
======================================
+ Hits 5946 5951 +5
Misses 1313 1313
Partials 410 410
🚀 New features to boost your workflow:
|
cf453eb to
d5fa703
Compare
d5fa703 to
07e46e9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Tailormap viewer API response model so the viewer can receive configured WMS styles per application layer (HTM-1875), enabling style selection/rendering in the frontend.
Changes:
- Extend the viewer OpenAPI
AppLayerschema to include astylesarray ofWMSStyle. - Populate
AppLayer.stylesin the backend map response using configured service-layer settings. - Rename
WMSStyle.legendURLtolegendUrlin shared OpenAPI schemas and update Java usage accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/tailormap/api/controller/ViewerControllerIntegrationTest.java | Extends integration test expectations to verify layer styles are present (but currently includes a JsonPath issue and debug printing). |
| src/main/resources/openapi/viewer-schemas.yaml | Adds styles to the viewer AppLayer schema. |
| src/main/resources/openapi/common-schemas.yaml | Renames WMSStyle property from legendURL to legendUrl. |
| src/main/java/org/tailormap/api/persistence/helper/GeoServiceHelper.java | Updates legend URL mapping/accessors to legendUrl. |
| src/main/java/org/tailormap/api/persistence/helper/ApplicationHelper.java | Adds styles to the viewer AppLayer map response payload. |
| src/main/java/org/tailormap/api/configuration/dev/PopulateTestData.java | Populates test data with configured WMS styles (incl. legend URLs) for verification. |
28996cc to
14f549c
Compare
2 tasks
14f549c to
7a9ddfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocks: Tailormap/tailormap-viewer#1141
Potentially breaking change is the rename of the
legendUrlto be consistent with frontend; this should not be a probles as it was not available for use before, however to be able to select style(s) for a layer, services will need to be refreshed so that the capabilities are reloaded