Skip to content

⛓️‍💥 HTM-1875: update viewer API model to provide styles to viewer#1593

Merged
mprins merged 2 commits intomainfrom
HTM-1875_provide_available_to_viewer
Feb 12, 2026
Merged

⛓️‍💥 HTM-1875: update viewer API model to provide styles to viewer#1593
mprins merged 2 commits intomainfrom
HTM-1875_provide_available_to_viewer

Conversation

@mprins
Copy link
Copy Markdown
Contributor

@mprins mprins commented Feb 6, 2026

HTM-1875 Powered by Pull Request Badge

blocks: Tailormap/tailormap-viewer#1141

Potentially breaking change is the rename of the legendUrl to be consistent with frontend; this should not be a probles as it was not available for use before, however to be able to select style(s) for a layer, services will need to be refreshed so that the capabilities are reloaded

@mprins mprins self-assigned this Feb 6, 2026
@mprins mprins added the enhancement New feature or request label Feb 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 6, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 7a9ddfe.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ormap/api/persistence/helper/GeoServiceHelper.java 84% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #1593   +/-   ##
======================================
+ Coverage      78%     78%   +1%     
  Complexity    132     132           
======================================
  Files         155     155           
  Lines        7669    7674    +5     
  Branches      703     703           
======================================
+ Hits         5946    5951    +5     
  Misses       1313    1313           
  Partials      410     410           
Files with missing lines Coverage Δ Complexity Δ
...lormap/api/configuration/dev/PopulateTestData.java 93% <100%> (+1%) 0 <0> (ø)
...rmap/api/persistence/helper/ApplicationHelper.java 89% <100%> (+1%) 3 <0> (ø)
...ormap/api/persistence/helper/GeoServiceHelper.java 83% <84%> (ø) 1 <0> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mprins mprins force-pushed the HTM-1875_provide_available_to_viewer branch 3 times, most recently from cf453eb to d5fa703 Compare February 6, 2026 15:04
@mprins mprins force-pushed the HTM-1875_provide_available_to_viewer branch from d5fa703 to 07e46e9 Compare February 9, 2026 08:57
@mprins mprins changed the title [WIP] HTM-1875: update viewer API model to provide styles to viewer HTM-1875: update viewer API model to provide styles to viewer Feb 9, 2026
@mprins mprins marked this pull request as ready for review February 9, 2026 15:53
Copilot AI review requested due to automatic review settings February 9, 2026 15:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Tailormap viewer API response model so the viewer can receive configured WMS styles per application layer (HTM-1875), enabling style selection/rendering in the frontend.

Changes:

  • Extend the viewer OpenAPI AppLayer schema to include a styles array of WMSStyle.
  • Populate AppLayer.styles in the backend map response using configured service-layer settings.
  • Rename WMSStyle.legendURL to legendUrl in shared OpenAPI schemas and update Java usage accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/test/java/org/tailormap/api/controller/ViewerControllerIntegrationTest.java Extends integration test expectations to verify layer styles are present (but currently includes a JsonPath issue and debug printing).
src/main/resources/openapi/viewer-schemas.yaml Adds styles to the viewer AppLayer schema.
src/main/resources/openapi/common-schemas.yaml Renames WMSStyle property from legendURL to legendUrl.
src/main/java/org/tailormap/api/persistence/helper/GeoServiceHelper.java Updates legend URL mapping/accessors to legendUrl.
src/main/java/org/tailormap/api/persistence/helper/ApplicationHelper.java Adds styles to the viewer AppLayer map response payload.
src/main/java/org/tailormap/api/configuration/dev/PopulateTestData.java Populates test data with configured WMS styles (incl. legend URLs) for verification.

Comment thread src/main/resources/openapi/common-schemas.yaml
@mprins mprins changed the title HTM-1875: update viewer API model to provide styles to viewer ⛓️‍💥 HTM-1875: update viewer API model to provide styles to viewer Feb 10, 2026
@mprins mprins added the breaking possibly breaking changes that need extra attention during upgrade label Feb 10, 2026
@mprins mprins force-pushed the HTM-1875_provide_available_to_viewer branch from 28996cc to 14f549c Compare February 10, 2026 09:22
@mprins mprins requested a review from matthijsln February 10, 2026 09:23
@mprins mprins enabled auto-merge (rebase) February 10, 2026 09:23
@mprins mprins force-pushed the HTM-1875_provide_available_to_viewer branch from 14f549c to 7a9ddfe Compare February 10, 2026 11:25
@mprins mprins requested review from a team, geertplaisier and steinkobben February 10, 2026 12:14
@mprins mprins disabled auto-merge February 12, 2026 07:54
@mprins mprins merged commit 3ad80d8 into main Feb 12, 2026
26 checks passed
@mprins mprins deleted the HTM-1875_provide_available_to_viewer branch February 12, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking possibly breaking changes that need extra attention during upgrade enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants